Editor/viewer lists cleared after an editor save changes

Drumble - February 10, 2009 - 14:19
Project:Coherent Access
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:MGN
Status:reviewed & tested by the community
Description

When I add an editor to a node, he is added correctly and can edit the node. However, after he saves changes, he and any other editors and viewers for that node are removed from their respective lists. If I edit the node as admin, the editor list stays intact.

#1

MGN - February 12, 2009 - 19:12

yes. I can verify that this is happening. I think I understand why, and will try to submit a patch soon.

#2

MGN - February 12, 2009 - 19:13

Note that it works correctly when you have 'trust editors' checked.

#3

MGN - February 12, 2009 - 21:57
Assigned to:Anonymous» MGN
Status:active» needs review

The problem is in coherent_access_shared_editing(). When 'trust editors' is not checked, the $private, $editors, and $viewers variables are not preserved when the editor saves the nodes. I fixed this by carrying these values through on form type 'value' elements. The patch is against the latest 6.x-1.x-dev version.

AttachmentSize
372138_coherent_access.diff 5.23 KB

#4

Drumble - February 16, 2009 - 14:23

Thanks MGN!

#5

MGN - May 15, 2009 - 03:57

@Drumble, have you had a chance to review the patch? Did it fix the problem?

#6

Jabzebedwa - September 24, 2009 - 19:36

MGN,

The problem is in coherent_access_shared_editing(). When 'trust editors' is not checked, the $private, $editors, and $viewers variables

I don't know where "coherent_access_shared_editing()" is, nor do I see a check box anywhere for "trust editors". If you'll be a little more informative with your instruction I'll be happy to test your patch and give you some feedback on it. I'm having this exact problem. Where exactly do I apply the patch?

Thanks,

Ben

#7

evoltech - October 15, 2009 - 21:09
Status:needs review» reviewed & tested by the community

@Jabzebedwa, @MGN is referring to a function called 'coherent_access_shared_editing' in coherent_access.module. This is the function that was patched in #3. @MGN is referring to the global 'Trust editors' setting in admin/settings/coherent-access.

I have tested this patch and confirmed it provides a bug fix to this issue.

 
 

Drupal is a registered trademark of Dries Buytaert.