When I add an editor to a node, he is added correctly and can edit the node. However, after he saves changes, he and any other editors and viewers for that node are removed from their respective lists. If I edit the node as admin, the editor list stays intact.

CommentFileSizeAuthor
#3 372138_coherent_access.diff5.23 KBMGN

Comments

MGN’s picture

yes. I can verify that this is happening. I think I understand why, and will try to submit a patch soon.

MGN’s picture

Note that it works correctly when you have 'trust editors' checked.

MGN’s picture

Assigned: Unassigned » MGN
Status: Active » Needs review
StatusFileSize
new5.23 KB

The problem is in coherent_access_shared_editing(). When 'trust editors' is not checked, the $private, $editors, and $viewers variables are not preserved when the editor saves the nodes. I fixed this by carrying these values through on form type 'value' elements. The patch is against the latest 6.x-1.x-dev version.

Drumble’s picture

Thanks MGN!

MGN’s picture

@Drumble, have you had a chance to review the patch? Did it fix the problem?

Jabzebedwa’s picture

MGN,

The problem is in coherent_access_shared_editing(). When 'trust editors' is not checked, the $private, $editors, and $viewers variables

I don't know where "coherent_access_shared_editing()" is, nor do I see a check box anywhere for "trust editors". If you'll be a little more informative with your instruction I'll be happy to test your patch and give you some feedback on it. I'm having this exact problem. Where exactly do I apply the patch?

Thanks,

Ben

evoltech’s picture

Status: Needs review » Reviewed & tested by the community

@Jabzebedwa, @MGN is referring to a function called 'coherent_access_shared_editing' in coherent_access.module. This is the function that was patched in #3. @MGN is referring to the global 'Trust editors' setting in admin/settings/coherent-access.

I have tested this patch and confirmed it provides a bug fix to this issue.

jgraham’s picture

Status: Reviewed & tested by the community » Fixed

Commited, sorry for the long delay thanks MGN and evoltech.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.