Closed (fixed)
Project:
Read More Link (Drupal 6 and earlier)
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Feb 2009 at 09:23 UTC
Updated:
28 Feb 2009 at 22:20 UTC
The current 3.0 version does a bunch of stuff before checking if the module should move the link:
function ed_readmore_nodeapi(&$node, $op, $teaser, $page) {
$enabled = variable_get('ed_readmore_readmore_tweak', 1);
$inlineflag = variable_get('ed_readmore_readmore_inline', 1);
$strong = variable_get('ed_readmore_readmore_strong', 1);
if ($strong) {
$strong_l = '<strong>';
$strong_r = '</strong>';
}
else {
$strong_l = '';
$strong_r = '';
}
$link_text = $strong_l . t(variable_get('ed_readmore_text', ED_READMORE_TEXT_DEFAULT)) . $strong_r;
$options = array('html' => true);
$readmore_url = l($link_text, "node/$node->nid", $options);
if ($enabled) {
...
It should probably look like this:
function ed_readmore_nodeapi(&$node, $op, $teaser, $page) {
if (variable_get('ed_readmore_readmore_tweak', 1)) {
$inlineflag = variable_get('ed_readmore_readmore_inline', 1);
$strong = variable_get('ed_readmore_readmore_strong', 1);
if ($strong) {
$strong_l = '<strong>';
$strong_r = '</strong>';
}
else {
$strong_l = '';
$strong_r = '';
}
$link_text = $strong_l . t(variable_get('ed_readmore_text', ED_READMORE_TEXT_DEFAULT)) . $strong_r;
$options = array('html' => true);
$readmore_url = l($link_text, "node/$node->nid", $options);
...
Comments
Comment #1
todd nienkerk commentedFixing typo in title.
Comment #2
todd nienkerk commentedFixed in the 3.x-dev branch.
Comment #3
todd nienkerk commented