After you closed my rotation support request (http://drupal.org/node/36570) I did some digging. And was wandering if this is the bug.

File: image_manip.inc {acidfree_rotate_image()}
Should line 87 not be changed from this $command = "{$exiftran_path} -rotate $angle $image"; to this $command = "{$jpegtran_path} -rotate $angle $image";

I think $exiftran_path is being used were $jpegtran_path should be used. I dont have exiftran installed so the jpegtran function always fires but the system call does not work because $exiftran_path is empty.

But When I change it I get a lot of error out put. And all the images (thumb and full) for the node = 0kb.

......5&MD¦”±¨5CòhwJh?­=Æ•‰m4m§t¥¦!t©PS¦Œµ,´‰€ìvö(¤òΏoçRiÜù“øi®>až”ƒîþ5#=eè²–3¡wÖØ#jÃ5›CC†)qÏáMâœ:Њ&¶ûÀú³€YÛ׊‚ÀÍYQ…úÒ±H“,JX(ÞÔ܍DlcÖ©-Ùk‡éUŸÅJ@Áâ nš Ž~•vԍ¬]œU´ãzß“éM¬p.T{Õ·]Ä/÷š²,7Š£Vź²¼Gш¨e¢ÚóKáÜ)ÑÀI÷’ÓÎÀu2,¾kp÷!—cRª‡±AU/ÏoqWX€£éY÷¤n’ÔÅ)˜nQíTå/ô«’…ÈöMÏßúV¨É£>rÊ>XçªÔ!®Öh<*;œ©ù_¨«) |å}ÅBQ¼Øâf-HV!ÉëLH¢EÄš­”Ré‰`ê
(SØ®¥ySõ8öÍsVé'öºn½¢8Î;MtqTÕ$µjÙ´æ±a+jÓüªd†$# T×ñîÃÖ¡]¹©g9„ŽØ¬úš«-˜ÓŠÐ·A¸ûVM£å{
ׄaÇ¥hö&æmÁ™‡­A2j{³w¹ªðÖª$1“ãuDùÏï*8<Öˆ‚Ú`Š¹ª°"®)Ú£XcÙŽqMaQîùºÓë9	À<Õ<code>warning: Cannot modify header information - headers already sent by (output started at /var/www/htdocs/projects/drupal_album_test/modules/acidfree/image_manip.inc:88) in /var/www/htdocs/projects/drupal_album_test/includes/common.inc on line 192.

Comments

vhmauery’s picture

vhmauery commented
Status: Active » Fixed

I don't know why I didn't look into this sooner. This is actually kind of embarrassing. I guess I need to RTFM a little more often. jpegtran writes the images to stdout unless you give it the -outfile option.

I have committed these changes to CVS and should be repackaged in about 8 hours.

NaX’s picture

NaX commented
Priority: Normal » Minor
Status: Fixed » Active

You must be tired of hearing from me.
Great, The rotation function is working great now, but. (Their is always a but, I think this is a easy one)

I tested it with jpegtran and it all worked fine, but when I cleared the Path to jpegtran in my settings, forcing it to use GD (I assume, since I dont have exiftran installed) then it rotates the image in the wrong direction.

check it out.

vhmauery’s picture

vhmauery commented

I do not see this on my site... The rotation works just fine with GD (I don't have jpegtran) and exiftran. I do not see how this could be a problem. It is an integer that gets passed to the image_rotate function -- 90 for clockwise and 270 for counterclockwise.

NaX’s picture

NaX commented

I had a look into this and I don't understand why this is happening. I see how it passes in the rotation (90 or 270). At first I thought it could be that the rotation function was being called 3 times for each image witch would explain it, but that does not seem to be the case.

I am going to try look into this again next weekend when I get time. If this seems to be a isolated case I would recommend closing this issue and if I find something I will reopen it.

vhmauery’s picture

vhmauery commented
Status: Active » Closed (fixed)