Hello,

I quickly translated the PO of the module into French (fr.po attached) for a site I'm currently working on.

Despite the fact that I translated all the strings and that the engine correctly imports them all (or so it says), the interface is incompletely translated (notably the "email this page" link). It might have to do with the module code. I haven't looked into it yet but it's on my to do list (unless it's already in the works).

CommentFileSizeAuthor
#2 374726.patch15.42 KBaufumy
fr.po12.87 KBFFred

Comments

seanr’s picture

seanr
he/him
commented
Component: Miscellaneous » User interface
Category: feature » task

Anyone able to complete this?

aufumy’s picture

aufumy commented
Status: Needs work » Needs review
StatusFileSize
new 374726.patch15.42 KB

fr.po file generated, attached as patch file.

There were some strings that had t() around variable_get, which I believe can be improved, but am not sure at this point what the alternative is.

What I did to create the fr.po file, was move the t() inside, so that the potx module could generate the fr.po file, then reverted back to original code, so that the forward module would work as expected.

module code

      '#title' => check_plain(t(variable_get('forward_link_title', 'Email this !type'), array('!type' => 'page'))),

temporarily changed to

      '#title' => check_plain(variable_get('forward_link_title', t('Email this !type', array('!type' => 'page')))),
seanr’s picture

seanr
he/him
commented
Status: Needs review » Fixed

The .po file is committed, however I can't do the t() calls as you suggest because then if the user edited those strings in the admin interface, they'd no longer be translatable. The entire string returned from variable_get() is what needs to be translated, not just the default value.

Status: Fixed » Closed (fixed)
Issue tags: -translation, -francais, -french

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +translation, +francais, +french

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.