The validation for the xmoov.php file in plugins/flashvideo_streaming/flashvideo_streaming.module was somewhat incorrect. Attached a patch.

CommentFileSizeAuthor
#8 flashvideo_streaming.patch3.67 KBjseffel
#6 flashvideo_streaming_patched.txt14.11 KBjseffel
#4 flashvideo_streaming.txt13.96 KBjseffel
#2 flashvideo_streaming_module_fix.patch2.31 KBjseffel
flashvideo_streaming.patch1.14 KBjseffel

Comments

jseffel’s picture

jseffel commented
Status: Active » Needs review
jseffel’s picture

jseffel commented
StatusFileSize
new flashvideo_streaming_module_fix.patch2.31 KB

Disregard patch above.

Created another one and also fixed a problem with flashvideo_streaming_flashvideo_get_file.

wibbla’s picture

wibbla commented

Hi how do I yse the patch
I copyd the file to the folder but noting heppens

jseffel’s picture

jseffel commented
StatusFileSize
new flashvideo_streaming.txt13.96 KB

Dont know how to apply patches in windows. I've attached the flashvideo_streaming.module (rename it to .txt, otherwise I couldnt attach it).

jseffel’s picture

jseffel commented

Forgot one thing.. use the "... drupal root" thing when you configure xmoov otherwise the wrong path is given to the flvplayer.

jseffel’s picture

jseffel commented
StatusFileSize
new flashvideo_streaming_patched.txt14.11 KB

Sorry. I attached the non-patched version. Heres the patched version.

attheshow’s picture

attheshow commented

jseffel,

If you can post your patch in a normal .patch file again, I'll get it added into the module this weekend.

jseffel’s picture

jseffel commented
StatusFileSize
new flashvideo_streaming.patch3.67 KB

Done in this patch:
* Changes in description for xmoov path
* Removed poss. to choose if we should use "... drupal root" (we cant execute PHP-files in files/ directory anyway)
* Proper(?) validation of xmoov.php path

We would probobly be better off by calling a hook in flashvideo_get_flashvars so other modules can add flashvars. As it is today flashvideo picks up the "streamer" varible from flashvideo_streaming which I think is somewhat wrong (should only be used for the RTMP-server) - which forces flashvideo_streaming to overwrite that variable.

attheshow’s picture

attheshow commented
Version: 6.x-1.5-beta1 » 6.x-1.x-dev
Assigned: Unassigned » attheshow
Status: Needs review » Fixed

Thanks jseffel! I like your layout of the xmoov-php file configuration much better than the original. I like how the file needs to be added into the FlashVideo module directory. I just applied the patch to the 6.x-1.x-dev version. The updated package should appear on the project page in the next few hours.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tomotomo’s picture

tomotomo commented

I think this still needs another patch, as in http://drupal.org/node/1038612