Use Drupal's date_format function to theme dates in mails

Ah, great. Thanks mglanznig! I'm moving this to patch, RTBC, so I remember to add it.

The code is good, but the patch file seems to be broken.
It is trying to remove the correct line and adding the old one.
Try this patch, should work fine.

The patch still needs to be committed, so we'll leave the status as RTBC for now.

Committed to all versions.

That patch has an error. Caused big headaches for our users....

It's calling format_date, but not passing in the correct timezone offset (0), so format_date assumes the user want's the site timezone (which is likely not GMT = 0).

To reproduce the error:

1. Set date form component to GMT
2. Set site timezone to America/Vancovuer
3. Create a form entry using the date: 1954-08-03
4. Form e-mail will show up as 1954-08-02 (- 1 day)

Attached is a new patch...

oops... forgot to change status

Thank dayre, committed to 2.x versions.

Please, fix it in the 5.x-2.9 too.
Thanks.

It is fixed already in 2.x, we just need to make a new release (it will be in 2.10).

Please, do it. You can help a lot for people using date field with mails.

When you will put out new fixed release? It's very annoying bug :-(

Anytime after #604958: %profile and %server default values broken is fixed. Seems like there are plenty of solutions, we need to find the correct one and apply it.

I think patch #10 was incorrect, because I am now experiencing that one-day-back error with timezone Europe/Amsterdam. It used to work because the timezone offset of strtotime() and format_date were cancelling each other. The patch caused format_date to assume GMT, while strtotime still used the system wide timezone.

The following would be better (note the +000):

$timestamp = strtotime($data[0] .'/'. $data[1] .'/'. $data[2].' +000');
$format = webform_date_format('medium');
$output .= ' '. format_date($timestamp, 'custom', $format, 0);

Edit:
One additional thought: as an internal check to see whether the right date is output, it is perhaps wise to check the hour + minute result of the format_date function. It should be 00:00:

$timestamp = strtotime($data[0] .'/'. $data[1] .'/'. $data[2].' +000');
if (format_date($timestamp, 'custom', 'H:i', 0) != '00:00') {
die('There are problems');
}
$format = webform_date_format('medium');
$output .= ' '. format_date($timestamp, 'custom', $format, 0);

strtotime() should always be in UTC I believe. But considering there are a hundred different ways that the timezone might be set somehow. The current patch should work for most users.

In Webform 3.x, we've fixed this by introducing a dedicated function webform_strtotime(), which uses the same approach Date module provides to force the timezone to UTC before running strtotime:

function webform_strtotime($date) {
  $current_tz = date_default_timezone_get();
  date_default_timezone_set('UTC');
  $timestamp = strtotime($date);
  date_default_timezone_set($current_tz);
  return $timestamp;
}

So in short my recommendation is upgrading to Webform 3.x, I'm not sure this will be correct in 2.10.

At http://nl2.php.net/strtotime I read: "This function will use the TZ environment variable (if available) to calculate the timestamp."

I will upgrade asap.

Another alternative is just installing the Date project, which sets the timezone to UTC for you. Though really I'd just recommend upgrading :-)

#21 suggests this issue is fixed, not active.