Closed (fixed)
Project:
CVS integration
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
20 Feb 2009 at 14:30 UTC
Updated:
12 Mar 2009 at 21:00 UTC
Jump to comment: Most recent file
When we apply for a CVS account and fill out the application form, cvs account user name is pre-filled and is read only text box. when we submit the form it shows error "CVS username field is required."
It is a bug as cvs user name text box is not editable.
To reproduce the bug follow following steps:
1. Go to CVS account application form "http://drupal.org/cvs-application" after logging in with your user name and password.
2. Fill in the details for the form and click the button "Request CVS account".
3. You will see the error "CVS username field is required.".
can anyone tell anything about this?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | cvslog_fix_reapplication.patch | 3.41 KB | hunmonk |
| drupal_error.PNG | 160.06 KB | agupta |
Comments
Comment #1
agupta commentedforgot to mention explicitly (though its obvious but still.....)it is happening on drupal.org site
Comment #2
dave reidComment #3
gábor hojtsyThe code for that form lives in CVS.module.
Comment #4
dwwThis is an old bug, and has nothing to do with the d.o upgrade. The bug only appears when someone re-applies for a CVS account after they've already been denied. There appear to be a few edge-case bugs in those code paths. I'll fix this when I get the chance.
Comment #5
agupta commentedhow could i now apply for CVS account?? is there any other way???
Comment #6
hunmonk commentedseems the easiet fix here is to simply pass the username as a value and use a separate form item to display it.
attached patch was tested for both new applications and reapplications, and appears to function perfectly.
Comment #7
dwwchx told me in IRC that setting #value for disabled elements was perfectly valid, along the lines of #380350-9: Editing release nodes without 'Administer projects' permission is broken because title + version are disabled. That's probably an easier solution in here.
Comment #8
dwwIn my local testing, this is all we needed: http://drupal.org/cvs?commit=176262
I locally applied the patch on d.o, and it seems to be working fine.