Documentation and code clean-up

Where can I download the imce_wysiwyg-HEAD module?

Here is my pached version.

It shows the brows button, but does not open the popup IMCE window.

I'll get on this in the next day or so. I have been flooded with thing lately.

Great work guys. Thanks for having started this project, it will be very useful and I think it will be the best compromise we will have ;)

I checked out HEAD from CVS. I played with it few minutes. Button is there when I click to insert an image, popup opens and I can upload, manage and set the image to use. This works all fine for me.
What's not working is inserting links, which also allows users to use IMCE to browse for a file on the webserver if needed, thus should allow the use of IMCE through this new bridge). The problem is that the input field ID (id property of the HTML element) where the path of the selected file is sent is not the same for image (src) and for links (href).

Modules used for my tests :

• IMCE 6.x-1.2
• IMCE Wysiwyg API bridge (missing version tag... I guess it is notmal because it is head and no official release is made yet, but at least I mention it in case it's a problem)
• Wysiwyg 6.x-1.0
• TinyMCE 3.2.1.1

I joined a patch, it's my first from TortoiseCVS (so be indulgent :P), I hope it will help... at least it is working for images and links, I could not test "Flash" which is also a different input field ID. When I enable "Flash" plugin in WYSIWYG API settings of TinyMCE, this editor does not work anymore, I never use this plugin and do not know if it's a known issue, maybe it will be worth creating an issue there but I do not have a clean install to test it.

No, I did not patch with #2 first.
So here is a second patch, not from CVS then but from HEAD with patch #2 and with use of encodeURIComponent. I did not encode the @ because it is was not encoded back then when it was passed through Drupal.settings.imce.url and it is not a user/browser input. Thanks for your advices it is much appreciated.

Thanks for the info about the Flash plugin, one less issue to start for me, and one less duplicate to mark for you ;)

subscribe

Ok then, sorry for the misunderstanding on my behalf. Here's the patch which merges my changes with your changes from CVS, and yeah it makes sense now, I guess it was too late for me yesterday ;)

About encoding I agree and I read previously that url() does this, unfortunately it must not be doing exactly the same than encodeURIComponent() because if the @ passes in url() the end of the returned URl is :
imce?app=tinymce|url@src
And with encodeURIComponent() :
imce?app=tinymce|url%40src
It works in both cases in IE6, FireFox 3 and Opera 9.6, but you are right, according to the RFC @ is reserved should be encoded.

So I checked the generated Javascript, it is indeed not encoded when using url() because the parameter $query when passed as a string is not going through drupal_query_string_encode, it must be passed as an array of key => value representing the variable => value of the desired querystring. So I modified this too, and put the @ back in imce_wysiwyg.module (doesn't change much, but I prefer doing these tasks on the server whenever possible.. I know I know, there's anyways a call to encodeURIComponent() in the .js file for the field_name, but if you prefer it the other way just modify the patch, at least now it is encoded in both places :P).

**EDIT** I believe other URL's built for FCKEditor, should have their querystring encoded like this too but I cannot test FCKEditor right now and I don't want to touch code I can't test, it's up for grabs for people using FCKEditor, until I find time to test FCKEditor.

I committed the patch by TheRec. Do you guys want a dev release? This is mostly your call Sun.

I've been lurking here for a while...fwiw, I'd love to see a dev release and would be happy to help test it.

I checked out the HEAD version from the repository, and it worked great in my dev environment, so I put it on the production server, and I'm not having any problems with it at all. Certainly a lot easier than muddling around in either the IMCE module, the wysiwyg module, or my theme.

I did, however, have to install the Administration Theme module, as IMCE was taking its styling from the main template (currently A3 Atlantis), which turned the "Upload/Resize/Send to tinymce" etc links at the top into white on white.

Thanks a lot for the work that's gone into this.

Installed successfully and working beautifully for me.
Drupal 6.9
IMCE 6.x-1.2
IMCE Wysiwyg API bridge 6.x-1.x-dev (2009-Feb-26)
Wysiwyg API 6.x-2.x-dev (2009-Feb-25)
Version 3.2.1.1 (2008-11-27)

Thanks so much for pulling this together, guys...

Working fine for me as well on several sites:
Drupal 6.9 and 6.10
IMCE 6.x-1.1 and 1.2
Wysiwyg API 6.x-1.0
TinyMCE 3.2.1.1