Needs work
Project:
Image Assist
Version:
6.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Feb 2009 at 23:00 UTC
Updated:
27 Feb 2009 at 23:28 UTC
Hello, it feels like the form for uploading an image is extremely complex. Most of the fields will be often unused. Here is a rough patch that simplified the form. A screenshot demonstrating what it looks like is at http://people.ubuntu.com/~mnuzum/tmp/img_assist_altered.png
I don't pretend to understand the complexities and full function of this form so consider this just an example.
| Comment | File | Size | Author |
|---|---|---|---|
| simpleform.patch | 1.22 KB | newz2000 |
Comments
Comment #1
sunThere should be a t() around the string, so it is translatable.
We should not alter those, because title and body are actually used by Image Assist (for the title and alt attribute).
The author fieldset is only visible for administrators. Wouldn't it be a good idea to keep it here, in case one is uploading an image on behalf of someone else?
The rest, I agree with. Though, bear in mind that other modules can advance the image node form. The "Rebuild derivative images" option for the image node add form was recently removed #196823: remove 'rebuild derivatives' from submit form, so it will no longer appear here (soon, when the next official release of Image module is out).
I wonder whether we want to change the logic to do the opposite? Iterate over the form, and just keep the form elements we want, resp. which are required for successful form submission? - meh, scratch that. We recently added CCK support to Image Assist, just to be able to add further meta data for image nodes and use that data in Image Assist.
Comment #2
sunas far as IA is concerned, we could change the #type to textfield and _replace_ the input format form element with a hardcoded #value that defaults to variable_get('filter_format_default', FILTER_FORMAT_DEFAULT)