Closed (fixed)
Project:
Date
Version:
6.x-2.1
Component:
Date API
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2009 at 01:38 UTC
Updated:
24 Feb 2011 at 10:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
oxofile commentedSame problem here, subscribing.
Comment #2
fischerj commentedsame for me, subscribing.
Drupal 6.10
Date: 6.x-2.0
Views: 6.x-2.3
PHP: 5.2.5
MySQL: 5.0.24
Comment #3
jeeves commentedSame problem here. My setup:
Drupal: 6.10
Date: 6.x-2.0
PHP 5.2.8
MySQL database 5.0.67
Comment #4
deshilachado commentedsame problem here
Comment #5
deshilachado commentedi just put in todys date by hand and it is also changed to 2009-01-01
Comment #6
karens commentedSome of the filter settings have changed and there is a chance you have old values stuck in a cache somewhere. Delete your filter, save the view with no filter on it (to be sure the all cached values get cleared out), then add the filter back in.
Comment #7
deshilachado commentedI duplicated my view, deleted the filter, saved the view with no filter on it, added the filter back in but the problem persists.
I also flushed all caches a couple of times.
Comment #8
karens commentedI need to see an export of a view that behaves this way so I can see how the filter is set up. And I need to know what kind of date field you are using (date, datestamp, or datetime) and how it is set up. You can show me this with an export of the date field (use Content Copy to export that).
Comment #9
deshilachado commentedfirst of all, thank you for the fast replies.
the field i'm using for the filter is set up as date
here is the export of the content type
and here is my view:
Comment #10
deshilachado commentedi use the field_aktion_enddatum for filtering
Comment #11
mastervissie commentedSame problem here, subscribing.
Comment #12
rsbecker commentedTry using today instead of now and see if that fixes the problem. Yesterday I tried to figure out how to put in default values for the date filter on a view. I could not do it numerically for month year, even though I tried 2007-01 and 2007-01-01. But I found that I could use the selector on the view setup page and put today in for the "to" date.
Comment #13
deshilachado commentedi tried using now, today, tomorrow, yesterday, 2009-02-28
but they were all changed to 2009-01-01 for the query
Comment #14
intrafusionSame problem for me, subscribing.
Comment #15
petey318 commentedsubscribing -
"now + 1 day" behaves the same way... 2009-01-01
Comment #16
deshilachado commentedI just changed to exposed filter and then the filtering works. Changing back to unexposed and the filtering doesn't work.
Comment #17
karens commentedI just committed a fix to -dev. The problem would only affect non-exposed filters that needed a default value computed. If you use the tarball, you won't see it until the tarball is updated. If you use cvs it should be there now.
Thanks for the examples of a view and a field, that helped a lot.
Comment #18
deshilachado commentedThank you for the fix, works for me! (I just learned how to check out modules from CVS: http://drupal.org/handbook/cvs)
Will there be a 6.x-2.0.1 or a 6.x-2.1 version soon?
Comment #19
karens commentedThere are always a few bugs in a new release. I'm going to wait and see if there are any other big ones reported right away before creating a new version.
Comment #20
dagmarHello Karen:
I'm think that one big bug that should be solved in the next realease is the related to custom format:
I have founded two issues related to this bug:
#363820: Escaped/Unrecognized Characters entered into custom default display format get shown for "to date" even if one does not exist.
#375864: Formatting issue
I think that this issue is critical for sites with custom date formats, like Latin American sites.
Sorry for my english
Mariano
Comment #21
Dave Hirschman commentedsubscribing
Comment #22
esskay commentedMakes "now" work fine. Thanks for the quick response.
Comment #23
strauch commentedHelllo,
i have the same problem is it possible to get a patch or something for this?
Thanks
strauch
Comment #24
prapse commentedsame problem here, subscribe
Comment #25
TyraelTLK commentedSame problem, subscribing
Comment #26
lxndr commentedsame problem - subscribing
Comment #27
espurnesI've the same problem. If I use 'now' the query filters with 2009-01-01 instead of the current date.
If I use an specific date works fine.
any suggestion?
any HowTo to explain what to do?
thx
Drupal: 6.10
Date: 6.x-2.0
Calendar: 6.x.2.0
PHP: 5.2.8
MySQL database: 5.0.67-community
Comment #28
dagmarKarenS says:
Then, please try date-2.x-dev.
Comment #29
espurnesThx, now it works properly.
:)
Comment #30
strauch commentedsorry but isn't it a little bit crazy to use a dev version on a live site because the release doesn't work? i would prefer a patch. But maybe there is no other way?
Comment #31
dagmarThis dev version only includes a few bug fixes. You can see the differences in the cvs messages.
If you prefer a patch, you always can create one making a diff from the cvs Here click on patch.
But I recomend use the dev version, until 2.1 version be released. Because as KarenS said, this version only includes a few bug fixes.
Comment #32
strauch commentedok thanks, i will use the dev version. Thanks for the explanation about the patch from cvs page.
Comment #33
webstylemedia commentedAgree!
Guys! Please don't do a releases until test all.
A big huge live site with many views has been broken after update!
PLEASE NEXT TIME TEST IT, TEST IT, TEST IT.
Better to have a dev version for a years, then buggy release versions.
Thanks.
Dmitry
Comment #34
karens commentedSo if there is a bug you assume I committed this without doing any testing? There was no reason for this comment.
Comment #35
benjf commentedI agree, no reason whatsoever for that comment. We have all experienced some frustration with this issue, and KarenS has been responding and updating code in a very timely fashion. I think we all should be saying Thank You. After all, this is OSS. Maybe YOU should have installed the update on a test site, before just going for it in production. Give me a break.
Comment #36
jgrevich commentedthanks for the quick update!
Comment #37
Andrew Schulman commentedsubscribing
Comment #38
webstylemedia commentedNo reason????
Why I am getting now (All Day) text at the end of half my CCK date fields?
Guys I have more than 20 date fields in different content types - it's very big problem for me. It's not a games.
Looks like a recent updates 2.0 and next dev - completely different from previous. There is a huge gap with it - I don't think you should release it as new update when you build new tables and move formats to it - as release without testing on dev version.
Tell me guys better - how to remove that stupid (All Day) - who ever need that text at all? It's just a datetime field in CCK. It's not period From-Till.
Thanks.
D
Comment #39
webstylemedia commentedbenjf, this was a bug in RELEASE version!!!!! No problems if it's in dev - but kerenS released a new version without testing it on dev versions. That even was not a 1.91 version and not 1.999version. And not RC, and not Alpha or Beta. IT WAS A FIXED NUMBER 2.0 VERSION!!!
Comment #40
webstylemedia commentedOkay guys for people who have a similar issue with (All Day) text.
At the file: date/date.theme
Comment line 300 and add next line like this:
//return trim(date_format_date($$which, 'custom', $format) .' '. theme('date_all_day_label'));
return trim(date_format_date($$which, 'custom', $format));
It will make that stupid text go away for ever (until next buggy update :-))!
Good luck guys!
PS. For module developers - issue appeared after very buggy automatic date format conversion upon a 2.0 version update. I dunno why but a some datetime CCK fields appear with (All day) text at the end. FIX IT PLEASE. And don't release a new FIXED NUMBER version until all tested in dev. Thanks.
Dmitry
Comment #41
bradezone commentedKarenS, thanks for the fix. I'm subscribing so I can be notified of the official update, which I'd rather use than a dev or nightly release.
this is a fairly major bug, so hopefully another official release is issued soon!
Comment #42
ron williams commentedA small note to webstylemedia, you should be a little more considerate to the hard working module developers on drupal.org. I don't see you making any contributions to the community aside from activity in 19 topics/issues (some being advertisements for your websites). If you have issues with a bad commit, then consider helping out instead of simply typing in all caps, using multiple exclamation points, and being generally negative to those who are the heart and soul of drupal.
Comment #43
chakrax commentedSubscribing. I have a subdomain I created to test updates before committing them to the live site, and I saw this behavior there, so I haven't put it on my production site. All users have that choice of testing changes on their own.
I'm grateful to KarenS for updating this module. It's volunteers like KarenS that make this site and others like this possible.
Comment #44
webstylemedia commentedRon Williams, I can contribute! And I tried! I even updated some modules (several "too busy developers" did not had a time to update from D5 to D6) and offered to post it here. But moderators here didn't provided me a CVS access due a rules that I can't update a modules of other people.
Please understand me right, I like Drupal and community and I understand that community trying to keep all very well controlled and doesn't allow different versions of the same modules, doesn't allow garbage, not well-formatted code or other things and that is okay and I appreciate that.
I really dunno how correctly write a patches (how to make it in correct format) so Drupal accept it. I don't really understand how get an access to CVS. And I found it's really hard to even post a case study! Too many rules for all of this!!!! That's why I don't contribute. But I appreciate that you keep Drupal secured from possible non-professional coders etc. I don't have any questions to drupal moderators on this and I accept this. (Maybe just it will be good if they can post a better guidelines for these questions - patches, CVS, case studies).
All I want is just keeping the same high standards in all your FIXED NUMBER releases.
Thanks.
D
PS. Ron if you or others have any questions - they may ask me - I will like to help. I am in biz for more than 10 years. Manage 2 web development and internet advertising companies. Started from coder. Have a great experience in Drupal and can answer almost any question. Just ask me. I can't sit in forums - because I have other job. Maybe if you can invite me in official contributors list I can offer more time and help to others in forums and groups.
Comment #45
Andrew Schulman commented@Dmitry:
This is a different issue, but for the record, a better approach is just to write a new theme function for the 'All day' label:
You could also return just an empty string, but be warned that that doesn't work if you're only showing the time, since then the whole date/time string is empty and something later on replaces it by '12:00 AM'.
Comment #46
saragc commentedHi,
Maybe it could be a good idea to post a warning about this bug in the download page?
Comment #47
saragc commentedHi again,
I've read this:
>I just changed to exposed filter and then the filtering works. Changing back to unexposed and the filtering doesn't work.
but after I installed the dev version it happens the contrary, I have to change it to unexposed to make it work. If it only works in this mode, should not be a warning in the download page, ot at least in the release notes, and also about the bug in general?
Thanks
Comment #48
omerida commentedUpgrading to dev didn't fix this for me. Changing line 439 in date_api_filter_handler.inc from
to
Fixed it for me.
Comment #49
mnasgowitz commentedHello.
I also have had issue with the 'now' feature. My goal is to simply add an 'up and coming' list of events on my site.
Anyway I just tried the fix that omerida posted and it worked fine for Drupal 6.10 and Date 6.x-2.0.
Thanks omerida and always thanks to KarenS for all the work!
Comment #50
Junro commentedHello,
This bug is really critical,
Solutions #40 and #48 don"t work for me...
I have 20 date fields, it's very critical problem for me.
All nodes created after february 24 have the 01.01.2009 bug. (only empty fields sure).
I'm not a develloper, I can't find a solution myself.
I'm sure Karens will ^^ we have just to wait...
Thanks Karens :)
Comment #51
karens commentedEveryone who is still having a problem should try this using the latest -dev version of Date, Views, and CCK (and Calendar if you use it). I cannot reproduce any problem in the latest code and I can't issue the fixed releases unless people confirm it is working. You need the latest -dev of Views and CCK because they have changes that could affect this. Both of them are due for new releases very soon, but for now you can get the fixes in -dev. After updating, be sure to clear all the caches (there's a button to clear the caches at admin/settings/performance) and run update.php to be sure there are no updates needed.
If there are still problems using the latest -dev versions of all these modules, then I need to know exactly what kind of fields and views you are creating by showing me exports of the fields and the views.
The solution in #45 is exactly the way the system is supposed to work, it was put into a theme so you could override it to say something else or say nothing. And that is a different issue that should not have been added into an issue that is already completely polluted by non-productive flames and complaints.
@webstylemedia, please quit telling me to TEST TEST TEST as though I'm too stupid to know that things need to be tested or too lazy to do it. If you repeat that one more time I'm going to just close this issue and any others you try to open because I'm tired of responding to it. If you don't know how to write patches there is no way anyone is going to give you cvs access, so you should not be surprised about that. Anyway, 'contributing to the community' doesn't mean committing code to cvs, it means providing patches, making constructive comments, providing detailed information about how to replicate the problems you see, doing some debugging on your own and reporting the results, etc. And you haven't done any of those things in this issue.
Comment #52
Junro commentedI have the lastest -dev version of Date, CCK, Views, Calendar. But I have the bug with nodes where Views and Calendar aren't used.
I'm using date cck fields and if they are no values, until to not display the date cck fields, 01.01.09 is displaying.
Date cck fields settings:
Text field with custom input format
Default value : Blank
Default value for To date : Blank
Numer of values:1
To date: Never
Granuality: Year, Month, Day
If I edit nodes with 01.01.09 bug, 01.01.09 is set into cck date fields where I haven't set a value. No way to erase it, 01.01.09 come back anyway.
These date cck fields are directly into nodes. No views here...
If you need something else... :)
Thanks
ps I only have this problem with nodes created since 01/03.
Comment #53
webstylemedia commentedHello, KarenS!
Sorry if I hurt you.
Can you at least write on the project page that these new updates are too much buggy and you recommend people do not update module and to use a latest available release candidate before fixed number 2.0? Btw what version it was? rc6 if I am not wrong?
Regarding help you to find it out - what info do you need from me? My sites have more than 60 modules - I doing updates to stable release versions regulary. Last time I made update of around 10 modules + updated a core drupal to d6.10.
What info do you need from me? All modules are latest.
I thought I already explained process how error appeared at the end of post #40.
Regarding CVS access - I don't need it - it just was an answer to Ron Williams about why I have so few posts. You, KarenS, just told me again more and more rules ("Anyway, 'contributing to the community' doesn't mean committing code to cvs, it means providing patches, making constructive comments, providing detailed information about how to replicate the problems you see, doing some debugging on your own and reporting the results, etc") - that is one more reason why I don't have any wishes to contribute.
Sorry, KarenS, please don't close this thread because others need a help. I don't have a problem after your fix in first dev version + All Day gone after my fix #40. Also I don't use Views (except 3 not important pages) - I use a custom module with custom queries for performance improvements.
I still think you built a very good module and really I can't live without it and without your work, so please don't be angry on me. All I wanted is just big red notice on the project page that NEW UPDATE IS DANGEROUS!
Thanks and sorry.
PS. Will not write anymore on this thread so please don't close it for others and don't be angry. Everyone make mistakes.
Comment #54
emok commentedI had the "2009-01-01"-problem after updating to date-6.x-2.0 and calendar-6.x-2.0. Switching to date-dev (actually, only the patch mentioned in comment #31) solved it without need to do anything else.
My filter is not exposed and I use Views-6.x-2.3 on PHP 4.3.11. At first I used CCK-6.x-2.1 (rather old now) and then I updated to CCK-6.x-dev, still working fine. I can attach the view export if desired, but as things work for me I guess only people who still are seeing the bug need to give more info.
Comment #55
karens commented@webstylemedia, OK, apology accepted. But I disagree that this update is dangerous, I had much much worse problems in rc6 and no problems at all in the latest release, and I have been working with many many other issues about things that were badly broken in rc6 and fixed in the latest code, so I do NOT think the solution is to go backwards or to warn people away from this release even though there may still be a bug in it.
I still cannot reproduce the bug, and emok cannot reproduce the bug. I am not saying there is no bug, just that it's unusual enough that I cannot reproduce it, and it does not affect everyone.
The end of post #40 is about how to hide the 'All day' text, which is not what this issue is about. Junro's post at #52 provides the kind of information I was looking for -- exactly what kind of field was used and how to reproduce the problem. I'll see if I can get the same results using that information.
Comment #56
iko commentedHi,
I installed the -dev version because of this issue ; but my own problem is not fixed : my date fields' default value is blank (not now), and the fields (when not completed) are automatically filled as "2009-01-01..."
(if I set the default value to now, the fields have a correct value ; but I need a "blank" value...)
Thanks,
Comment #57
Junro commented@ iko, it seems to be exactly the same problem than me, see my comments.
Comment #58
Andreas Wolf commentedI can confirm the error.
I set up the current release version of views, cck on a fresh drupal install.
I've created a custom node with date fields and made a view for it with a filter.
So I have exactly 1 node in the system. There where no module updates.
Using the filter the date in the query was set to 2009-01-01.
Now I've installed the -dev version of date.
The error is gone with a hidden filter, but if I expose the filter now the date in the query has the right values for month and date, but the year is set to 0009 instead of 2009.
If you press the apply button the date is set right.
So I suspect there is still something wrong with "now", since this was the default value I chose.
Hope this helps somehow.
Comment #59
deshilachado commented@iko, Junro & Andreas Wolf
Comment #60
Junro commentedok, here the new issue
When Date CCK Fields are empty, 2009.01.01 is display
Comment #61
Junro commentedSo, this issue should be "Fixed" I think.
Comment #62
iko commentedtu as été plus rapide que moi Junro ;-) field with "blank" default value automatically filled as "2009-01-01"
so... two issues for the same bug...
Comment #63
Junro commentederf lol tant pis, je vais mettre le mien sur duplicate. Le tien est mieux expliqé
Comment #64
headkit commentedsamesame like iko
Comment #65
grendzy commentedThe latest code from the DRUPAL-6--2 branch resolves this issue for me.
KarenS, your efforts are truly appreciated.
Comment #66
Crell commentedRunning Views 2.3, CCK 2.1, and Date 2.0 I can replicate this problem. The dev release of Date fixes it. Moving back to fixed.
Comment #67
wvd_vegt commentedHi,
Although the dev branch from 2009-Mar-09 fixes the now problem, it still does not work correctly when one uses a date modifier like now+1 or now-5. Then it just returns the now value and totally ignores the modifier.
Comment #68
svdoord commentedI'd like to confirm that the fix in -dev solves this issue for me. As it seems to be an important issue to many of us, would this fix alone maybe warrant a minor update of the module (2.0.1)?
Thanks!
Comment #69
Anonymous (not verified) commentedsame problem,
subscribing
took a while after
php upgraded on my server from 5.1 to 5.2.9
had to delete old view and clear caches
had been using the php4 patch with 5.1
now all events showing up in calendar, with only those for next 60 days in upcoming block and sorted by date
got upcoming events working with the date 6.x-2.x-dev
thanks, karen
drupal 6.10
php 5.2.9
Comment #70
jpp commentedIf you change the format from select to text the default will work without switching to the dev version.
Comment #71
splashworx commentedKaren, you are a star. If I lived next door I would buy you a beer (or 3).
I appreciate the effort, many thanks.
I have 'now + 7days' date filters happily displaying correct rounds within my football website. The latest dev version for D6 works a treat.
Comment #72
Andrew Schulman commented-dev of 3/18 breaks this again for me. When I edit the view everything looks fine: dates are from now to now +6 days. See coming-events-view-edit.png. But the block itself thinks today is January 1: see coming-events-block.png.
Comment #73
aren cambre commentedhttp://drupal.org/node/404272 is a duplicate of this. Subscribing to this thread. Also running into the same issue on a view with a date filter.
Comment #74
karens commented#67 if you're using a modifier like 'now +5' it won't work, you have to tell it what kind of units, the pattern is 'now +5 days' or 'now -90 minutes'.
Everything works absolutely fine in the latest -dev version of Date and Calendar.
Please do *not* reopen this issue, it's totally polluted by confusion over which version is being used when and what problems were in existence are different points in time. If you have a problem in the latest -dev code, start a new issue.
Comment #75
j0rd commentedgetting the same issue. I will upgrade to -dev while I wait for latest version.
Comment #76
sjh-1 commentedWhile the dev version fixes the basic problem for me on standard comparisons, it still seems to fail on "between" type ranges. Instead of giving a less than current date on the end range, it has =2009-01-01. I avoided this by simply having two filters, one less than and one greater than, but it seems that the fix in -dev may not be complete.
Comment #77
vivianspencer commented#70 worked a treat for me, I didn't have to switch to the dev version
Comment #78
strauch commentedi upgraded to 2.1 and it didn't work again :-(.
whats going wrong?
thanks
strauch
Comment #79
strauch commentedset status to active
Comment #80
Crell commentedComment #81
karens commentedPlease read the new TROUBLESHOOTING tips at http://drupal.org/project/date.
This is fixed in *-dev*, no one said it was fixed in 2.1.
Comment #82
strauch commentedMhhh how does the development work? i thought the dev version will finished in the next release. As example 6.x-2.0 is release and 6.x-dev has the bugfix now 2.1 is released on which codebase is the realase, when it is not the dev version?
When will this fix is back in the release version. it is for me unknownable why this bug isn't fix in the release? the troubleshooting doesn't help me. sorry all the things works in earlier version i don't understand why the last release doesn't work the release is only 1 day old?!
should i open a new bug report?
Comment #83
karens commentedReleases like 2.0 and 2.1 are released and never touched again so the only time they are 'the latest code' is at the moment they are released. The next fix after that goes into -dev, which then becomes 'the latest code'. It doesn't matter how old 2.1 is, there are fixes since it was released and those fixes are only in -dev.
The next release will include all changes since the last release, then we start over again where that will be the latest code only until there is a bugfix that goes into -dev.
So the -dev version is always the newest code, every other release gets outdated immediately.
Comment #84
Andrew Schulman commentedThe release notes for 2.1 say that it's fixed in 2.1.
Comment #85
strauch commented@Karen,
ok but when 2.0 released there was the first time the bug is present, the next dev Version after the release is bugfixed, i installed this dev and didn't updated the next dev, because i thought in the next release this bugfix is included. Now 2.1 is released and the bug is there again, what happend to the bugfix?
or can't i use the word now and have to use today, or is it translated in the new version, and i have to use the german word (jetzt)?
Comment #86
chakrax commentedUsing 'today' instead of 'now' worked for me (under the view - Filters), without having to go to the dev release.
Comment #87
timb commentedEveryone please always TEST, TEST, TEST on your own production sites. Never upgrade modules on a 'big huge live site' w/o properly testing them yourself.
Comment #89
johanvdw commentedThere seems to be some conflicts with the internationalization module. My upcoming block works fine in English, but not in other languages.
Comment #90
RichieB commentedUnfortunately using 'today' does not work with me with the 2.1 release. The 2.x-dev release has other bugs. Can someone point me to a working version?
Comment #91
aren cambre commentedI noticed this didn't make it to 6.2.2 per its release notes. (But I was impressed at the number of fixes you implemented in 6.2.2!!)
Could we get an idea of when this will make it into a release? Thanks!
Comment #92
Junro commentedHave you still got this problem??
Comment #93
aren cambre commentedI'm still on a DEV version because per per #81, it's not fixed in 2.1, and 2.2's release notes don't say this issue is fixed.
Comment #94
Junro commentedYou should try the 2.2 version... There are not all issues fixed in releases notes I think.
Comment #95
aren cambre commentedThanks, but I am going to wait on confirmation from KarenS. This issue contains no .patch files, so I cannot verify for myself without backing up my database and installing the new module. (Have to back up because if the new version does not contain this fix, I have to revert to my prior state.)
Comment #96
deshilachado commentedI'm using Date 6.x-2.2 and "now" filtering works for me, thanks KarenS! As far as I can tell this is solved for good.
Comment #97
grendzy commentedComment #98
aren cambre commentedgrendzy: This query is not why Karen requested the issue be closed. This is germane.
Comment #99
karens commentedThis issue is closed. Leave it closed. If there are still problems in the latest -dev code, they need a new issue. The way you can tell that this issue is too polluted to use any more is that when you refer to 'this problem' or 'this fix', it's impossible to tell exactly what you mean. It is a waste of time to keep saying vague things like 'This is still not fixed', which is not enough information to respond in any way.
The original problem as reported for version 6.x-2.1 should be fixed. If it is not, I need a new issue that 1) is based on the 'latest code' (see the project page for the definition of that, this issue is for version 6.x-2.1, which is definitely *not* the latest code), 2) makes it clear whether the troubleshooting steps on the project page have been tried, and 3) identifies exactly how to reproduce any remaining problem (which will probably require at least an export of the view and and export of the date field with a clear explanation of what you did, what you expected to see, and what you saw).
Comment #100
aren cambre commentedThank you!
Comment #101
musko commentedTHANK YOU
Comment #102
2dareis2do commentedthankyou.