Dev snapshots showing up as official releases

#386442: Dev release in Official releases. is a duplicate issue, different project: http://drupal.org/project/mobile_codes

Hrm, evil:

mysql> SELECT nid, version, rebuild FROM project_release_nodes WHERE rebuild = 0 AND version_extra = 'dev' AND version_patch IS NULL;
+--------+-------------+---------+
| nid    | version     | rebuild |
+--------+-------------+---------+
|  94702 | x.y.z       |       0 | 
|  96095 | HEAD        |       0 | 
| 173678 | 5.x-1.x-dev |       0 | 
| 184431 | 6.x-2.x-dev |       0 | 
| 192063 | 5.x-1.x-dev |       0 | 
| 267664 | 6.x-1.x-dev |       0 | 
| 325789 | 6.x-1.x-dev |       0 | 
| 349903 | 6.x-1.x-dev |       0 | 
| 358549 | 6.x-1.x-dev |       0 | 
| 358573 | 6.x-1.x-dev |       0 | 
| 361435 | 6.x-1.x-dev |       0 | 
| 365995 | 5.x-2.x-dev |       0 | 
| 369972 | 6.x-2.x-dev |       0 | 
| 381026 | 6.x-1.x-dev |       0 | 
| 382226 | 6.x-1.x-dev |       0 | 
| 382700 | 6.x-1.x-dev |       0 | 
| 382712 | 6.x-4.x-dev |       0 | 
| 382716 | 6.x-4.x-dev |       0 | 
| 382818 | 7.x-1.x-dev |       0 | 
| 382832 | 6.x-2.x-dev |       0 | 
| 383146 | 6.x-1.x-dev |       0 | 
| 383392 | 6.x-2.x-dev |       0 | 
| 384098 | 7.x-1.x-dev |       0 | 
| 384166 | 6.x-1.x-dev |       0 | 
| 384428 | 6.x-2.x-dev |       0 | 
| 384524 | 6.x-2.x-dev |       0 | 
| 384580 | 6.x-1.x-dev |       0 | 
| 384912 | 6.x-1.x-dev |       0 | 
| 385410 | 6.x-1.x-dev |       0 | 
| 385538 | 6.x-1.x-dev |       0 | 
+--------+-------------+---------+
30 rows in set (0.02 sec)

The first one is expected, but none of the others are. :( I thought this might have just been my own stupidity when repairing things from #376666: Release node created without title by "preview", though I already had fixed the 4 -dev snapshots from that issue. So, there seems to be a bug here, and I bet it's in the CVS integration code that's altering the release node form. Indeed, I just reproduced the bug myself, so it's not even in the class of "project admins don't see it" bugs. ;)

As a short-term hack, I just ran SQL to repair all those back to be dev snapshots. But, I need to track this down and fix it for real. Sadly, I have to leave in ~5 minutes to be offline most of the day, and then I leave at 6am tomorrow morning to catch my flight to DC, so it's entirely possible this will be broken all weekend.

Indeed, this was busted in the cvs integration code, although I think the cleanest way to fix it is actually a patch for both cvs.module and project_release. The problem was that the cvs integration was unsetting the #value element that holds the -dev vs. official bit. It seems better to just move where in the form that bit lives so that a) it's not in harm's way where cvs.module is messing with it, and b) there's less hackery to get the value to propagate into the $node->project_release array. Since it's just a #value, anyway, there's no UI to worry about where in the form it shows up.

looks good.

Committed, deployed, and did the last cleanup of the DB for -dev nodes that had been edited in the meantime. I also cleared the release download table cache so there's nothing funny going on with those.