Add permissions, modify how permissions are used, and allow editing of revisions without them becoming live

Subscribing. This is exactly what I'm looking for. Being able to apply one's workflow to revisions is a huge plus.

Note - make sure you uncheck the box:

Exempt administrators from revision moderation

under admin/settings/revision_moderation

so that users with "adminster nodes" perms will not cause the node edit to go live immediately (bypass moderation).

Maybe I made a mistake, but I encountered a few problems with this patch. I activated the module, edited my content types to create new revisions and make them go into moderation by default. I created a user who is able to create content, but hasn't the administer nodes permission, neither view, edit, publish or delete revisions permissions.

• If I create a new node or edit an existing node with this user, I get an "Access denied" error after clicking on "Save". Maybe a "View own revisions" permission would be useful
• If I create a new node with this user, I get an "Access Denied" and the node is neither published (although the "Published" checkbox is ticked in the content type options) nor it appears in the list of pending revisions. So one (administrator) have to know the exact URL to access it and edit it. If it is edited, then it goes into revision moderation as expected. This is clearly a bug ; when a node is first created, either it's "first revision" should go into moderation, or it should follow its settings (in this case, to be published right away).
• If I edit a node, the revision goes into moderation, and I can see that the new revision is not the "active" one, but still the entire node becomes invisible to visitors, as if it was unpublished, like when revision moderation isn't activated

Is someone able to reproduce these ? As I'm not using any Action, Rule or standard Workflow I think it comes from the patch (original Revision Moderation was working).

I am not defaulting to "create new revision" on the content type and my users have edit revision permissions so I imagine it's one or both of these causing the problem. I will try creating a new user right now that doesn't have edit permissions perm and see what happens.

...

I just tried the following:

1) auth user with perms to create content only and create new revision unchecked for the module - I could create content - no errors
2) changed create new revision to checked - I could still create content
3) got access denied error when going to edit content
4) added edit own content perm for the auth user
5) edited content from #1 & #2 successfully
6) tried this with a content type that uses workflow and another one that doesn't

Sorry. Not sure how to reproduce.

Subscribing, this is what I'm looking for.

Hi all,
You may find this new module (plus its documentation and 3 step-by-step tutorials) useful: Revisioning.
Let me know how you went.

This seems to be exactly what we are looking for here :-) I'll take a look at it.

I switched over from Revision Moderation to Revisioning. I still ended up creating a custom action to ease the Workflow+Revisioning process. The process is like:

1) creation > draft
2) draft > review
3) review > live which triggers my custom action that:
a) publishes current revision
b) creates new revision (as pending)
c) changes state back to draft

The revisioning module + module grants worked for us.

I have create new revisions option checked in my site but the problems is,during change of state author still able to edit the node.

Is it related to content revisioning or I missed some access control permission.

*subscribing*

subscribing. Hopefully we can apply this to drupal 5 as well.