I upgraded my site from 4.6.3 to CVS and it seems that comments are now disabled by default on forum topics, when they were previously enabled. Not sure if this is a code problem, or a setting in the DB that got twiddled during the upgrade.

Comments

Wesley Tanaka’s picture

Everything works fine for the uid=1 user. It's just other users that have this problem. The object coming out of node_execute doesn't have a comment field set. Maybe it has to do with the fact that the form doesn't have any UI for whether or not comments are allowed?

Wesley Tanaka’s picture

Here's a patch that sets a default for $node->comment (based on code I saw in comment.module for setting the radio button initially) if $node->comment isn't already set when the node is passed in for saving.

$node->sticky and $node->promote being unset aren't as big of a deal because non-sticky, non-promoted seem like reasonable defaults. But I think they maybe also should get set to their default values explicitly for robustness sake.

Wesley Tanaka’s picture

Status: Active » Needs review

forgot to set patch status

Cvbge’s picture

I can confirm that after applying this patch forum posts by anonymous have comments enabled (my default setting).

There's still one problem - when you, as admin, edit the forum topic, the Authored field is not set and you have to set it to something. It should be set to anonymous IMO.

Wesley Tanaka’s picture

#4, Unless you think that this patch is causing the problem, my suggestion is that you file that as a separate issue so that the two issues can be tracked separately.

Cvbge’s picture

It happens without your patch also.

Wesley Tanaka’s picture

Would someone be willing to commit this?

Wesley Tanaka’s picture

Status: Needs review » Closed (duplicate)

oops

Cvbge’s picture

Duplicate of http://drupal.org/node/40563 (never can find it...)