node_save() doesn't set $node->comment

I'm confused on this one - check comment_nodeapi, 'validate'. The $node->comment is being set there, to the default READ_WRITE (which I think is the right setting, not DISABLED) - why isn't it becoming a part of the $node? Isn't validate supposed to be called before save?

in validate you can't change anything. validate validates.

This is the same patch as wtanaka's, but removes the useless set in comment_nodeapi, validate.

+1 to Morbus's patch. And definitely keep it READ_WRITE. (This also fixes http://drupal.org/node/41152 )

Sorry, forgot to set the status -- this does the job (Morbus's patch)

Ugly patch. Why do we set that field in node_save()? We don't do that for any of the other 'default values'?

You're right. Attached a new one.

Tested, works as expected.

Why are we providing a form value for a comment option in node.module? This does not make sense.

Previously, we were doing this in comment_nodeapi 'validate' - that code still remains, actually, and is removed as part of the original patch. Chx tells me that validate no longer (or maybe, never did - I dunno) modifies the form variables, so it can't happen there. The only other place it *could* happen would be in comment_nodeapi 'insert' and 'update', right? In which case, that'd be an entirely new query, just to set the node.comment? Need direction for proper handling of this.

This is all, IMO, on the wrong track.

For one, we shouldn't be reverting to the default in any case. If an admin set it, just because a user edits it doesn't mean it should revert. And it doesn't have to.

formsapi gives us:

  $form['user_comments']['comment'] = array(
    '#type' => 'value',
    '#value' => $selected,
  );

Merlin, you are on the right track. Let's see this version.

I moved the prepare op so that patch is smaller. To my eyes, this seems correct. The prepare bit happens when the node is new, otherwise node_load loads $node->comment. The form part is correct: admins can change this, users are not presented with this change but in place there is a value typed field (which is immutable) with same value.

I thoroughly tested this patch, creating different users (non admin) before and after applying the patch. Before applying it, SELECT comment from node where nid=NODE# returned 0, and on the site, no comments being added was possible. After applying, nid=NODE# returned 2, and commenting was possible.

Tested http://drupal.org/files/issues/node-comment_1.patch just posted by chx. Works perfect. +1

Nothing. When the form is built, the node->comment gets a value and that won't be overwritten in form builder.

Committed to HEAD. Thanks.