In order to be able to edit a user's subscription settings, I would expect to need the following permission right:d "administer simplenews subscriptions".

It's working fine in most cases, except in one place. Indeed, in function "simplenews_subscription_manager_form", a permission string of "administer newsletter" is needed in order to edit subscriptions. I believe this permission check is too strong for this context. The permission "administer simplenews subscriptions" would be more suitable.

I've attached a very simple patch which fixes the problem.

Thanks,

jf

CommentFileSizeAuthor
simplenews-edit-subscription-permission.patch562 bytesjfduchesneau

Comments

sutharsan’s picture

sutharsan commented
Status: Needs review » Fixed

You are right, thanks! 'administer simplenews subscriptions' is a recent change and I did not realize this use.
Patch committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.