I have successfully converted a personalized style to work with phpbbforum in drupal page mode.
If u are interested I just made a script to edit my previous css adding #phpbbforum-page before every declaration, and adding something like this at the top of stylesheet.css:
#phpbbforum-page ul {
list-style-type: none;
list-style-image: none;
background: none;
}
#phpbbforum-page li {
list-style-type: none;
list-style-image: none;
background: none;
}
Maybe others reset should be done for this and/or other tags..
Now I see all ok, but I have to edit images paths handy to work in drupal page because css variables like:
{IMG_BUTTON_TOPIC_LOCKED_SRC}
are not setted.
This is the script I wrote:
#!/bin/sh
# Convert styles to phpbbforum
PREPOST="#phpbbforum-page"
if [ -z $1 ];then
echo "Usage $0 file.css"
exit 1
fi
CSSFILE=$1
while read LINE
do
DIRECTIVE=`echo $"$LINE" | grep "{"`
if [ -z $"$DIRECTIVE" ];then
# NORMAL LINE
echo $"$LINE"
else
# FOUND CODE TO EDIT
ONELINE=`echo $"$LINE" | grep "}"`
if [ -z $"$ONELINE" ];then
# MULTI LINE CODE
DIRECTIVE=`echo $"$DIRECTIVE" | sed s/{//`
DD=`echo $"$DIRECTIVE" | cut -d',' -f1`
while [ ! -z $"$DD" ]
do
echo -n $PREPOST $"$DD "
DIRECTIVE=`echo $"$DIRECTIVE" | cut -d',' -f2-`
if [ $"$DD" == $"$DIRECTIVE" ];then
DIRECTIVE=""
DD=""
else
DD=`echo $"$DIRECTIVE" | cut -d',' -f1`
echo -n ", "
fi
done
echo " {"
else
# ONE LINE CODE
echo $PREPOST $"$DIRECTIVE"
fi
fi
done < $CSSFILE
exit 0
Tnx for your good work
Comments
Comment #1
vb commentedThanks for sharing your way of changing css.
>I have to edit images paths handy to work in drupal page because css variables like:
{IMG_BUTTON_TOPIC_LOCKED_SRC}
In my phpBB3 *-embed.css files i have changed these lines either.
Also lines with dimensions of images.
Comment #2
subcomandante commentedHi vb,
there is no plan to let these variables "dynamic" changing them by the module also because of language specific images?
Comment #3
vb commentedIt is smarty vars.
There is no need to change them in html templates. They work.
I do not know how it should be setted on-the-fly in css files.
Comment #4
subcomandante commentedwell, it's related to the way phpBB itself shows the stylesheet:
instead of phpbbforum:
Comment #5
vb commentedThanks, i will think how to implement this
Comment #6
vb commentedFixed in alpha4
Comment #7
vb commentedYour script does not work for me on common.css file. #phpbbforum-page on every line. Please, attach working yours as the attachement.
Comment #8
subcomandante commentedI attach the prosilver common.css with #phpbbforum-page nesting (appended txt on filename because of file upload extension limits).
If you want I can make and upload complete prosilver and subsilver themes.
In this file you can delete html and body section because they never appears in embed mode.
To have a "static" css with images and image sizes I do the follow:
1. Go to forum page and sign down SID and USERID
2. Go directly on /style.php?sid=SID&id=USERID&lang=en (only one language with static method)
3. Download the resulting css, name it stylesheet.css, move it to the theme folder deleting others css
4. Edit this stylesheet.css nesting all with #phpbbforum-page (run the script or edit it by hand)
This way I have all images paths and sizes done by smarty.
One question: what's changed in alpha4? Is now possible to have css embedding with /style.php?sid=SID&id=USERID&lang=USERLANGUAGE into drupal?
Tnx
Comment #9
vb commented>what's changed in alpha4? Is now possible to have css embedding with /style.php?sid=SID&id=USERID&lang=USERLANGUAGE into drupal?
Yes! And no need to get rid of smarty vars. You should do nothing with them exept for adding #phpbbforum-page.
When you will make new css, please, send me by email all changed css for prosilver and subsilver with #phpbbforum-page
Script does not work for me.
Comment #10
vb commentedPlease read the release notes on download page before upgrading to alpha4
Comment #11
subcomandante commentedgreat! I mark this as fixed because I tested it and now it works as expected.
I open a new issue for css conflicts here http://drupal.org/node/397162.
Tnx for your good work!
P.S. (I'm new on drupal, so I don't know if users changing to fixed is a good way or they should let you know it's fixed and wait you do it, let me know)