Hi guys,
I started a new issue for this task because it's stand alone.
As said in http://drupal.org/node/389648 css conflicts could be avoided in phpBB themes by adding #phpbbforum-page to every class in the css.
I attach php original prosilver theme edited this way and if it's ok for you I will do the same for subsilver.
The best way to themeing phpBB should be:
1. Have two styles in phpBB, let's say:
prosilver
prosilver-embed
2. When you direct access phpBB you should see prosilver theme
When you access phpBB inside drupal page you should see prosilver-embed theme
(the prosilver embed theme should have the #phpbbforum-page stuff)
But now you can only have one theme, I think it's because of the new css access method (am I wrong?)
The miracle would be have a new configuration setting in the phpbbforum settings page wich should let the user choice the style to use inside the drupal page (as gallery2 embedding module)
So, by now, you can have only one theme with phpbbforum-page stuff in css and test follows:
In my tests it's all ok, there is only one issue when you need to go to the ACP the first time and need to re-authenticate yourself.
When you see that page the forum is already in iframe and you do not have the #phpbbforum-page div id and it don't get yet the ACP style, so there is no style on that page.
The second issue is you have no style if direct access phpBB forum.
btw, this issues would be solved if phpbbforum module switch again between two styles (keeping current css access method by style.php, it's important to not loose this great functionality).
Finally, the attached file is to convert original prosilver theme substituting theme folder (do not forget to refresh the theme in phpBB forum STYLE page in the ACP!) or you can edit theme.cfg renaming to a new one forking the original prosilver theme (the best way) and enabling it on the ACP.
If you need more info please let me know,
Tnx
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | css.tgz | 1.34 KB | subcomandante |
| #2 | stylesheet.css_.zip | 2.59 KB | subcomandante |
| theme.tgz | 78.59 KB | subcomandante |
Comments
Comment #1
vb commentedPlease upload for subsilver2
I will include both styles in alpha5 css
Comment #2
subcomandante commentedHere we are!
Subsilver2 only have one stylesheet.css, so I'll attach only this file.
Comment #3
vb commentedThanks.
in alpha5 i think i have fixed this issue. Wait a bit.
Comment #4
Steel Rat commentedI'm completely confused about getting the phpBB theme to show up at all in the drupal page. The install instructions for the phpbbforum module are difficult to follow. Does anyone have more comprehensive instructions?
Comment #5
subcomandante commentedwow, it seems very good now, cleaner installation and out of the box integration ;)
Comment #6
vb commentedI have fixed in alpha5 a couple of bugs in your css files from automatic transformation, please take this in account and replace yours.
links.css and stylesheet.css from subsilver2.
Comment #7
subcomandante commentedtnx,
I have a little problem here. the style seems not working as expected and I have a:
onload_functions is not defined
styleswitcher.js
in firefox error console
EDIT:
To let me better understand:
In alpha5 version when phpbbforum is configured to work inside drupal page it calls style.php to get parsed stylesheet, but does it not switch between two styles yet, is it right?
I mean, it get the default/user phpBB3 configured style. This way I have to install prosilver-embed theme/template into phpBB3 and make it default theme/template to see it in action inside drupal page. But if I direct access the forum going to /phpBB3 (for instance) I get prosilver-embed theme/template right?
Or you coded something styleswitcher use to switch between the full and the embed style and it not works for me because of the error I'm getting?
Tnx for your huge help.
Comment #8
subcomandante commentedOhh, I got it working!!!
The problem is in the styles you are deploying in the alpha5 version (also in previous ones) you do not include imageset so you can enable the all style in phpBB3.
I created an imageset folder inside prosilver-embed style (copy&rename current prosilver imageset) and I'm now able to enable it in phpBB3 forum (without marking it as default style) and now it works as expected!!!!
If I direct access phpBB3 I get prosilver style, if I go to phpbbforum inside drupal page I get prosilver-embed style!!
the error "onload_functions is not defined" still remain but dunno if it matter now :D
Comment #9
vb commentedfixed onload_functions is not defined in
phpbbforum 6.x-2.0-alpha6
You must set as default original theme.
User can select his original (not the embed) theme but theme-embed must exists and be active.
In *-embed theme you can set imageset from original theme.
Comment #10
vb commentedDo not forget to replace medium.css and large.css (missed })
Comment #11
subcomandante commentedit's fixed here too :D
this module is going better and better.
it would be better if it was already included in the official phpbbforum version. It took a bit to me to understand this thing and it's not explained in the INSTALL.txt. Including it in the *-embed distributed will solve a lot of users headhacke ;)
tnx!
Comment #12
subcomandante commentedComment #13
subcomandante commentedI'm reopening it because I'm starting from scratch and noticed in css folder inside phpbbforum module some files are not updated with #phpbbforum-page prepend stuff. As it is now your module is re-setting drupal theme css and it's results in a wrong style displayed.
I attach updated files, the code is more clear than my english :D
Please check to see if I forgot some statements..
Comment #14
subcomandante commentedsorry, need to update version too.
Comment #15
fizk commented