Hi,

When a new revision is created, the log message is currently not being saved as the wrong field is being accessed. Simple patch attached.

Cheers
Karthik.

CommentFileSizeAuthor
#3 page_2.patch597 bytesZen
#1 page_1.patch534 bytesZen
node_43.patch732 bytesZen

Comments

Zen’s picture

Zen commented
Component: node.module » page.module
StatusFileSize
new page_1.patch534 bytes

As requested, patch now applies to page.module rather than node.module. Though we now have ['log']['log'] :P

-K

cjm’s picture

cjm commented

Hi Zen,

I've tested the patch against drupal-cvs and it does allow for correct saving and display of log messages in page revisions. However, a couple of issues I noticed (this is my first post to drupal issues, so feel free to shoot me down if I'm wrong):

- this patch was not taken against the drupal tree / cvs
- story and page module implementations of node_form are now inconsistant (ie, $form['log'])

Also another issue (requiring a seperate issue report?), is that the previous log message is shown by default when editing a story/page. This seems to go against the natural of logs, espeically considering that revisions are optional at each edit).

Zen’s picture

Zen commented
Title: Revision Log field not saved in node_save() » Revision Log field not saved in node_save() : page.module patch
StatusFileSize
new page_2.patch597 bytes

Hi cjm,

Thanks :) I'd noticed this happening in the page and book modules, but not in the story module.

New issues created:
book.module
story.module

The page.module patch attached to this post is identical to the previous one, except for a formatting fix. And both have been taken against the current HEAD.

Also, please open a separate issue for the log message bug you mentioned.

Cheers
-K

Zen’s picture

Zen commented
Priority: Critical » Normal
Status: Needs review » Closed (fixed)

This doesn't apply any longer. Use 39114.

Marking as closed.
-K