Description

Please check: Link.

-K

CommentFileSizeAuthor
story.patch596 bytesZen

Comments

Zen’s picture

Status: Active » Needs review
dries’s picture

killes?

moshe weitzman’s picture

story_form() doesn't have any log field at all right now. looks inconsistent to me, so i'd support this patch. was this deliberately omitted from story.module?

killes@www.drop.org’s picture

Status: Needs review » Needs work

Indeed, i did not add a log field for stories. So this patch does not apply. I am ok with adding a log field, if that is consensus.

Zen’s picture

When I put together this and other related patches, book, story and page all had a log message textarea. Story has mysteriously disappeared since.. I also notice that these textareas were previously in fieldsets which have also mysteriously vanished.

Moreover, I would prefer (atleast via an option) to have this field for all basic content types. It doesn't make sense to offer a "Create new revision" checkbox, but no log field.

_A_ log field appears upon creation in the outline tab.. but whether this is related to the node in question or the book page is unclear..

Cheers
-K

Zen’s picture

Title: Revision Log field not saved in node_save() : story.module patch » Revision log field not displayed in story module
Priority: Critical » Normal
Status: Needs work » Active

Added a more accurate title..

-K

morbus iff’s picture

I believe the log field disappeared in story.module due to http://drupal.org/node/34920 ("Removes the log message field from story module, which was accidentally put there during the forms API conversion (pointed out by Thox)").

Zen’s picture

The basic premise of adding a log message field was to enable better management of revisions. Considering the fact that all basic nodes have revisioning enabled, it is self-contradictory to not have a log message field.. Q.E.D.? Alternately, there should be no revisioning support for node types without a log field..

The lack of a fieldset for the log message also doesn't make sense to me - isn't this why fieldsets can be left uncollapsed by default? If it's not important, leave it collapsed.. If it is, leave it uncollapsed by default.

I don't use the book module enough to see what's going on with the outline tab and its log message field.

Anyways, as in my previous post, I'd like to see the log message field in all node types. I personally will find it very useful for annotations etc. besides revisioning..

Thanks :)
-K

morbus iff’s picture

In my opinion, Zen, you've failed to grasp the meaning of fieldset, relying instead on it's visual appearance in Drupal. Fieldsets are meant to be used to group likeminded fields together. Having a fieldset for one item (the Log entry) is, IMO, retarded - there are no other like minded fields sharing that fieldset with it, so the use of the actual fieldset tag is Wrong (tm). Using a fieldset in this case, to get that visual collapsible appeal, is the same dangerous slope as tables for design.

Zen’s picture

Agreed.. which is why, I'm reopening (as we speak) the issue you've linked to suggesting that said field should be stuck into publish options, along with its "like minded" companion - "Create New Revision"..

-K

Zen’s picture

Status: Active » Closed (fixed)