Contact module category update issue + _validate, _submit conversion

Blatant error. Patch recalled :P

-K

Updated code.

Cheers
-K

Removed '' from around the %d..

-K
P.S and thanks cvbge :)

wrong patch submitted :/

-K

Ah, but I had to try.. Patch attached. Please also look into the following URLs:

Example query with comment: http://drupal.org/node/2497
Pretty much every query: http://drupaldocs.org/api/head/file/database/updates.inc/source

Cheers,
Karthik.

Thanks :)

-K

Sure. Can you commit this now though? I will have to do some reading before getting this sorted.

Cheers
-K

Besides the previous fixes:

-Conversion to _validate + _submit model..

-Split replaced by explode - faster

-Fixed typos: Recipient

-Fixed weight defaulting to -10

-Popped mail subject formatting into a t()

-Popped '--' formatting into a t()

Cheers
-K

The weight issue has been fixed elsewhere.

Besides all the above fixes, this patch:
-does a lot of documentation fixing/rewriting.
-general formatting fixes (which makes the patch look very big :S).
-renamed contact_user_mail form functions to contact_mail_user for consistency.

I unfortunately still haven't got my head wrapped around the use of url() or l(), and the seemingly inconsistent use of the absolute_url flag everywhere. So I've left those as is, and will address them if needed later on.

Thanks
-K

Just noticed a missing comma. I've also removed the link to the ?q=profile page. This is dependant on the profile module and shouldn't really be here..

-K

Reopening for related issue. This is also an amalgam of fixes for some of the contact module issues reported + others.. I thought it best to just maintain one patch rather than hop around here and there..

Attached patch:

• Adds missing validation etc. for contact_admin_delete.
• Fixes a bug in contact_admin_edit where the edited category name wasn't being displayed.
• Adds separate status messages for "Category added" and "Category updated".
• Redirects the user to the home page after making a site-wide contact form submission. [31002]
• Adds a breadcrumb (that just says "Home" by default) to the site-wide contact page. [38357 - Jax]
• Shifts settings to a tab in admin/contact. [28060]
• Reorganises menus as a result.
• Adds a prominent link on the admin/contact page to the menu module, indicating the presence of a disabled menu link. Since the menu module is optional, I've added a module_exist() that lets the user know that he has to enable the module (if false).. I couldn't think of any _clean_ solutions to add the menu configuration to the same section..
• Comments all functions.
• Re-orders all functions in a logical manner (resulting in the monster diff..).
• Adds typo/language/formatting fixes.

I believe that covers it. Please let me know.

Thanks :)
-K

This column-wise diff might ease some of the pain of reviewing :)

Thanks
-K

Besides the above fixes, attached patch:

• Removes unnecessary $user global
• Adds watchdog messages for category addition, updates and deletion. The watchdog messages use the 'mail' category.
• Fixes the settings link in help.
• Fixes my erroneous // style.

Please review.
Thanks
-K

Thanks for the review webchick :)

Attached patch:
-keeps up with HEAD
-replaces drupal_goto with return (where applicable) as per Adrian's patch. I've used return ''; to implement a return to the frontpage. I trust this is fine.
-removes all sprintfs and replaces with . notation.

I've not done anything about the "update user" comment as it's imo fine as it is. The nature of the 'update' is made evident by the following statement.

Please re-review - thanks :)
-K

I'm going to set this to RTC:

a) Webchick has reviewed the code end of things and was only unhappy about a couple of cosmetic issues.
b) I've fixed and reviewed these issues: i.e. the use of sprintfs.

Thanks
-K

ah. My cvs version was stuck at 1.41. I've added in the 1.42 'www.drupal.org' -> 'drupal.org' patch.

Thanks
-K

(patches cleanly against 1.42).