Download & Extend

Prevent deleted newsletter during sending procedure

Project:Simplenews
Version:6.x-2.x-dev
Component:Usability
Category:feature request
Priority:normal
Assigned:Sutharsan
Status:closed (won't fix)

Issue Summary

If someone deletes a newsletter which has not been sent yet to all recipients (sending in process), there will be a lot of error in the log but the user will not be informed about it.
I think if someone tries to delete the newsletter wich is not sent yet to all recipents, the user should be warned and the sending process must be stopped.
It is very important to a large number of recipient (The sending process takes a long time)

Comments

#1

Assigned to:Anonymous» Sutharsan

#2

Title:Deleted newsletter node during sending procedure» Prevent deleted newsletter during sending procedure
Version:7.x-1.x-dev» 6.x-2.x-dev

Although Simplenews can now handle deleted emails better, preventing would be good. However this should be combined with a 'cancel send' option.

#3

Status:active» closed (won't fix)

I have investigated this and come to the conclusion that I will not fix it. It is an architectural problem. The only way to really prevent deletion of a newsletter, it to remove permission when emails are pending. But that would result in a access denied error, which is very confusing. The only thing left to do is to show a message upon deletion that pending newsletters will not be send.
The attached patch takes care of updating the email spool and showing the message. It is committed and will be available in the next 6.x-2.x-dev release.

The solution would be an architectural change where emails are generated and stored when the send command is given. But this change is not in scope of a 6.x-2.x release.

AttachmentSizeStatusTest resultOperations
simplenews.392956.patch1.27 KBIgnored: Check issue status.NoneNone

#4

Late change.

AttachmentSizeStatusTest resultOperations
simplenews.392956-1.patch1.33 KBIgnored: Check issue status.NoneNone
nobody click here