Invalid arguments supplied for foreach() ... menu.inc... line 258

Hi,

Thanks for your replies.

should the code on that line be changed to add a check on the $data variable?

something like:

	if (is_array($data)) {
		foreach ($data as $k => $v) {
                      ...
                }
        }

Anyway,

I ended up modifying menu.inc to add the check before the foreach statement:

original was:

function menu_unserialize($data, $map) {
  if ($data = unserialize($data)) {
    foreach ($data as $k => $v) {
      if (is_int($v)) {
        $data[$k] = isset($map[$v]) ? $map[$v] : '';
      }
    }
    return $data;
  }
  else {
    return array();
  }
}

this was changed to:

function menu_unserialize($data, $map) {
  if ($data = unserialize($data)) {
        //check if $data is an array before running foreach
	if (is_array($data)) {
		foreach ($data as $k => $v) {
	      if (is_int($v)) {
	        $data[$k] = isset($map[$v]) ? $map[$v] : '';
	      }
	    }
	} else {
                //error with $data - output $data and $map to watchdog
		$x_map = implode(":",$map);
		watchdog("foreach error","<pre>data =" .$data . "\n map = " .$x_map. "\n</pre>", null,WATCHDOG_ERROR);
	}//end fix
    return $data;
  }
  else {
    return array();
  }
}

not sure if this should be committed but it helped a lot to track down where the problem was.

Yes I've read your comments - it was a problem with some 'page arguments' not using array() in a custom module.

But what I'm saying is that it would have been easier if the menu module had a check on the $data variable and output a more informative error message instead of letting users find out where the problem is by disabling / enabling modules one by one. This one is a huge problem especially if the site is using a lot of modules.

So I think that menu.inc line should be changed to add the check on the variable. I've seen other system modules with checks on variables before running the foreach() command - why can't this line have a check? - saves users/developers a lot of time.