Move dblog settings to general logging & alerts page [#394382]

Currently the only settings DBlog offers is located on a separate page. This is a waste of code and too complicated for users. The attached patch simplifies the form element, fixes a bug where the default value would always be the same and moves it to the general logging & alerts settings form, which is created by system.module, like you can see in the screen shot.

Comment	File	Size	Author
#6	dblog_cleanup_03.patch	6.45 KB	dawehner
#5	dblog_cleanup_02.patch	3.01 KB	xano
#2	dblog_cleanup_01.patch	2.99 KB	xano
	dblog_cleanup_00.patch	2.96 KB	xano

Comments

Comment #1

xano

he/they

English

Southampton

commented 7 March 2009 at 18:54

Comment #2

xano

he/they

English

Southampton

commented 7 March 2009 at 18:58

Status	File	Size
new	dblog_cleanup_01.patch	2.99 KB

Comment #3

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 6 April 2009 at 07:49

I agree that the "database logging" form is too small to warant it's own page/tab/form. Applied the patch and it works as advertised. Manually reviewed the patch:

The following is a bit of a strange construct:
```
+  $buttons = $form['buttons'];
+  unset($form['buttons']);
+  $form['buttons'] = $buttons;
```
I guess it should either be preceded by a comment (something like 'ensure that the buttons are displayed at the bottom of the form') or replaced by something like:
```
$form['buttons']['#weight'] = 100;
```
```
The maximum number of rows to keep in the database log.
```
Since the title reads 'Database log entries to keep', it might make sense to talk about 'entries' instead of 'rows' in the description too?