Remove comment.module patch

Assigning to myself to review.

I do not see how to implement chunk 1 with the link altering API. I added a "jobtrack_link_alter()" function to the module and then visited the page in question, and no links are passed in. Is the link altering API only for nodes, not for comments?

I suppose the jobtrack module could redefine theme_comment_wrapper() using theme_registry_alter(), but that seems as ugly to me as providing an optional patch. Is there a simpler alter function allowing me to only alter one element, similar to form_alter?

I did remove the final two chunks, moving them into form_alter() as recommended.

What's the purpose of this patch at all? You say it is optional - so it's not part of the normal install process, right?

The patch is explained in INSTALL.txt, step 0.

OK, but I don't get it. INSTALL.txt says

it streamlines jobtrack tickets by removing comment-specific titles and links when used for jobtrack tickets

What does this mean?

Thank for the feedback, Neil. Sadly, I can't seem to make the _link_alter function do what I need, nor have I figured out how to get rid of the other patch hunk. Fortunately these are just optional cosmetic changes, however I would love to figure out how to do them without the patch. I'll leave this issue open hoping that someone else may come along with a solution, or that I'll find time to dig into it again and figure something better out.

@rohit: it removes some of the standard text output by the comment module when users are commenting on tickets. For example "Post a comment" is removed, and the individual "reply" links are removed. The patch is purely cosmetic and thus is completely optional.

I am unable to remove the final two pieces of this patch. Postponing this ticket for now in the hopes that someone will come along with a solution.

Closing ticket -- if it becomes possible to remove the rest of the patch, this should be done in the new 'support' module which replaced jobtrack.

If the purpose of the patch is to remove the "Reply" links from Support ticket nodes, you could use the Flatcomments module instead. The "Add new comment" link below the first post will not be displayed when "Location of comment submission form" of the content type's Comment settings are set to "Display below post or comments".

Thus I think this patch can safely be removed from the distro.

Additional ideas in this ticket:
#655646: bad idea: comment customization

This should provide the desired functionality without hacking core.

Thanks! It's always fun committing a fix for an issue opened >2 years ago! :)

As this may not be desired behavior for all installs I added configuration options for this. I also made both of these disabled by default. Committed here:
http://drupalcode.org/project/support.git/commit/ebb3248

Needs to be ported to the 7.x branch.

Redone for D7.

http://drupalcode.org/project/support.git/commit/ca6cf68a607581c4ca395a9...

Not going to re-open such an old issue, however there is a bug with D6 version. Don't ask me how I found it. :)

By implementing theme_registry_alter, you are forcing Drupal to use just that function and then the theme does not get a chance to rewrite it. What you are trying to achieve, can be sorted by removing the support_theme_registry_alter and support_comment_wrapper replacing it by preprocess function preprocess_comment_wrapper such as:

function support_preprocess_comment_wrapper($variables) {
  if ($variables['node']->type == 'support_ticket' && variable_get('support_disable_post_comment', FALSE)) {
    $variables['content'] = str_replace(t('Post new comment'), '', $variables['content']);
  }
}

just in case anyone else will stumble upon this...

Can confirm comment #18. Attached is a patch that is working for us.