Closed (won't fix)
Project:
e-Commerce
Version:
4.6.x-1.x-dev
Component:
-- other --
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
2 Dec 2005 at 05:33 UTC
Updated:
22 Sep 2006 at 05:12 UTC
With the way they tax in Canada this needs to work ;-)
To duplicate the problem add a tax rule for Ontario at 8% and make an address in Ontario. When checking out you'll notice the 8% is not added.
The problem is in the tax.module line 80
if ($states[$billing->state] == $rule->realm_value
The $state array is built up by calling address_get_address() which is only a list of US states.
I've attached a patch so that if the country is US then it will do this but if not then it will leave it be.
Thanks,
Tim
btw, the Component drop down box on this issue form doesn't have the new tax.module
| Comment | File | Size | Author |
|---|---|---|---|
| tax.module.patch | 964 bytes | Timotheos |
Comments
Comment #1
solipsist commentedThe tax module doesn't work with other countries either, the tax is calculated as $0.00 despite the tax rules. I have set up a twenty-five tax rules for all European Union member countries to account for 25% VAT.
Comment #2
mass0ud commentedThis (http://drupal.org/node/39653) is a great patch. One small change, however, would improve it dramatically. And, that is a drop-down box for selecting the state/provice/region. Otherwise, there is a potential for a huge problem. Please read what is below, and if I am wrong (which I hope I am), please let me know.
Currently, users type-in their province, instead of choosing it from a drop-down list. If they type the province different from what you have put in the tax rules that you have created, no tax is calculated.
For example, if in the rule you spell the state/province/region as 'on', but they enter 'ON' or 'Ontario' or 'ONTARIO' or any other variation of the provinces name, no tax is calculated. Guessing all the combinations of what users may enter is practically impossible, especially if you have long names such as 'New Brunswick'.
If you go ahead and process their payment, you MUST pick up the tab for the unpaid taxes of the customer. Because, under the CONTRACT LAW, they enter into a CONTRACT with you for the TOTAL amount that you show them which doesn't include the tax. But, as a merchant you have an obligation to pay the Canada Reveneu Agency all the taxes that you are supposed to collect on your sales.
This problem also exists for other non-US jurisidictions which have taxing regulations similar to Canada.
Regards,
Massoud
Comment #3
rickvug commentedSee http://drupal.org/node/75339 for a new temporary solution to this problem if you are in Canada.
Comment #4
simeWe are not supporting 4.6 now. Please re-open if any problems.