In the shopping cart when you review your order you can change the billing address. By this time the tax has all ready been calculated so if the billing address is changed to another region then the taxes may by wrong. For example, if changed from a state with no taxes to a state that has a sales tax.

I would think the addresses should be printed out (no drop down) with a link to change them. Clicking on the link will go back to the address page and the reinitialize the tax rules once it's changed.

Tim

CommentFileSizeAuthor
#3 address.module_1.patch4.82 KBTimotheos

Comments

matt westgate’s picture

matt westgate commented

I agree. Care to submit a patch for this?

Timotheos’s picture

Timotheos commented
Assigned: Unassigned » Timotheos

I was afraid you say that ;-)

I'll take a closer look tomorrow after some sleep and give it a go.

Tim

Timotheos’s picture

Timotheos commented
Status: Active » Needs review
StatusFileSize
new address.module_1.patch4.82 KB

Ok here's the patch for this problem.

But don't order yet... it also covers http://drupal.org/node/30794 and fixes this http://drupal.org/node/37220

Now there's one thing that has me stymied. If you click the address change link on the review page it goes back to cart/checkout which wipes out the info. So basically the $txn object is wiped out and the form is blank and the user would have to re-enter all the info again. Not the best. How can I stop this?

Thanks,
Tim

vitamin-1’s picture

vitamin-1 commented

Timotheos,

thank you for your patch, now anonymous purchases works fine, but there is one problem here: anonymous user can submit form with blank fields. There is no valifation at all!

Timotheos’s picture

Timotheos commented

Hi vitamin,

Glad it worked for you. The anonymous checkout in ecommerce is in a bit of disarray at the moment with some patches waiting in the wings. If you don't mind hacking the address module a little more you can follow my tip at http://drupal.org/node/37220#comment-58208 to validate any field.

Tim

iokevins’s picture

iokevins commented

Thanks for this patch, it solved nearly all my troubles. :)

One note for anonymous purchases, one might want to restrict access to the store/history/0 page (modules/ecommerce/store/store.module) thusly: ;)

175 /*$items[] = array('path' => "store/history/$uid", 'title' => t('order history'),
176 'callback' => 'store_user_history', 'access' => $user_access, 'type' => MENU_CALLBACK);
177 */

Not sure this breaks anything else.

Otherwise anyone in the know seems to be able to publicly access store/history/0 and view customer billing and shipping data. x_x

I have updated http://drupal.org/node/39655 with this bit of news as well.

Kevin

iokevins’s picture

iokevins commented

Whoops. Last bit was meant to state "I have updated http://drupal.org/node/39655 with this bit of news as well."

iokevins’s picture

iokevins commented

Whoops. Last bit was meant to state "I have updated http://drupal.org/node/37220 with this bit of news as well."

sime’s picture

sime
any/any
Location Melbourne
commented
Component: address.module » cart

bump, worth review

brmassa’s picture

brmassa commented
Status: Needs review » Closed (duplicate)

a newer patch is provided on http://drupal.org/node/140628