It wasn't possible to updated cvs repositories.

Line 718 in cvs.module was:

db_query("UPDATE {cvs_repositories} SET name = '%s', root = '%s', modules = '%s', diffurl = '%s', newurl = '%s', trackerurl = '%s', method = %d WHERE name = '%s'", $repo->name, $repo->root, $repo->modules, $repo->diffurl, $repo->newurl, $repo->trackerurl, $repo->method, $name);

but should be:

db_query("UPDATE {cvs_repositories} SET name = '%s', root = '%s', modules = '%s', diffurl = '%s', newurl = '%s', trackerurl = '%s', method = %d WHERE rid = '%s'", $repo->name, $repo->root, $repo->modules, $repo->diffurl, $repo->newurl, $repo->trackerurl, $repo->method, $rid);

i.e. $name wasn't working, and we should check on $rid instead anyway

Comments

jakeg’s picture

Status: Reviewed & tested by the community » Fixed

committed a few weeks ago, forgot to update this

Anonymous’s picture

Status: Fixed » Closed (fixed)