Hi

I installed drupal-cvs and og-cvs as off 4pm PST Dec 4th. I create two groups and then create a user and I sign them up for only one of them. When they login the number of subscribed users to both groups has been incremented.

I tried this when creating the account as admin and when a user registers - both times users are subscribed to all (both) groups instead of only the one selected on the registration page.

Cheers,

Mark

CommentFileSizeAuthor
#7 og_register.patch824 byteskilles@www.drop.org
#3 og_6.patch893 byteskilles@www.drop.org

Comments

moshe weitzman’s picture

moshe weitzman commented

i can confirm this behavior. whomeevr fixes this should be careful that the user can't subscribe himself to closed/moderated groups.

moshe weitzman’s picture

moshe weitzman commented

gerhard - i think you added this code. perhaos you can investigate.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Active » Needs review
StatusFileSize
new og_6.patch893 bytes

here is a patch, can somebody test it?

moshe weitzman’s picture

moshe weitzman commented

gerhard - any chance you could test this a bit and commit? needs fixing on 4.6, 4.7, and HEAD. Not sure if checkboxes look different with new formapi and thus the patch will differ for 4.6

killes@www.drop.org’s picture

killes@www.drop.org commented

I don't think this needs fixing in 4.6, I cannot reproduce the problem there.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Needs work

I've tested it but now no mail at all gets sent. Will look into it a bit more.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new og_register.patch824 bytes

Better patch.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

Committed, and yes, the change was due to the form API.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)