Hi there,

thank you for this great module. I've updated to 5.x-1.20 and I'm pretty happy with the module. But please have a look at forward_page(). There you return 'No path was selected to forward'. Please add t() to this string.

In the same function i like it much better to transform the $node->title to uppercase:

$node = new stdClass();
$node->title = ucfirst($path);

Furthermore it would be great I've the user could choose the email format ($headers['Content-Type']). Right now the format is set to 'text/html; charset=utf-8'. That's okay for most of us. But I think some users just want to send plain text emails. So I've set it to 'text/plain; charset=utf-8'.

It would be great to read some opinions about my proposed changes. Thank you!

CommentFileSizeAuthor
#3 forward.module-plain-text.patch1.28 KBbjacob

Comments

seanr’s picture

seanr
he/him
commented
Status: Active » Postponed

I implemented the t() function. As for uppercasing the titles, I think it's better to leave them the way the author of the original node intended them to be. If you're adamant about it, you can always do this at the theme layer (override the functions in forward.theme in your theme's template.php, being sure to rename the functions phptemplate_forward...). The third part of that is going to be a more in depth feature change as it'll require admin settings and such. I will do it, but need some time to get around to it.

bjacob’s picture

bjacob commented

Thank you for your reply. You're right. The second thing with the uppercase title can be achieved by overwritting it via the theme function. Sending the mails via plain text would be great! If you need some help let me know. It shouldn't be a problem. What do we need in order to let the user choose the format? Mmh, I've tested it and created a patch. Check it out and let me know if it's okay.

bjacob’s picture

bjacob commented
StatusFileSize
new forward.module-plain-text.patch1.28 KB

Here's the patch.

Edit: Maybe we have to move the drop down to the 'Administrative Options' fieldset because the email format setting is used for both email types (postcard and email). Maybe we have to unset some fields like forward_header_image which can't be used within plain text emails. The theming function could also be extended by supplying a html and a plain text version...

john.oltman’s picture

john.oltman commented
Status: Postponed » Closed (won't fix)