Hello,
I found several issues/bugs in the latest version of the forward module (25/09/2005):
In Administer->Settings->Forward:
- The states of the "Use Node Type in Link" and "Prepend Subject With Sender's Name" checkboxes are not saved.
- The content of the "Flood Control Error" textarea is not saved.
- The content of the "Thank You Message" textarea can not be translated.
- The Flood Control limit is actually equal to 10, whatever is set in the admin settings.
- The strings "Message Body" and "Your Name" can not be translated.
I fixed them the "quick and dirty" way :
- The third argument of form_checkbox function calls was changed from NULL to "1".
- The variable 'forward_flood_error' is misspelled ('forward_flood_error_msg').
- It seems that the content of 'forward_thankyou' can not be translated if the corresponding 'variable_get' call is put in a definition. So every occurences of FORWARD_THANKYOU were replaced inline.
- The "variable_get('forward_flood_control')" was missing.
- Added the missing t('...').
Could anyone review this patch ? Thanks ;-)
| Comment | File | Size | Author |
|---|---|---|---|
| forward_several_issues.patch | 7.32 KB | Moxide |
Comments
Comment #1
seanrThese all look good. As soon as I get my CVS set up again (new computer), I'll apply the patch. Thanks.
Comment #2
seanrThis patch has been applied to the 4.6 version. Thank you for your assistance.
Comment #3
Moxide commentedYou're welcome !
Comment #4
(not verified) commented