Hello,

I found several issues/bugs in the latest version of the forward module (25/09/2005):

In Administer->Settings->Forward:

  1. The states of the "Use Node Type in Link" and "Prepend Subject With Sender's Name" checkboxes are not saved.
  2. The content of the "Flood Control Error" textarea is not saved.
  3. The content of the "Thank You Message" textarea can not be translated.
  4. The Flood Control limit is actually equal to 10, whatever is set in the admin settings.
  5. The strings "Message Body" and "Your Name" can not be translated.

I fixed them the "quick and dirty" way :

  1. The third argument of form_checkbox function calls was changed from NULL to "1".
  2. The variable 'forward_flood_error' is misspelled ('forward_flood_error_msg').
  3. It seems that the content of 'forward_thankyou' can not be translated if the corresponding 'variable_get' call is put in a definition. So every occurences of FORWARD_THANKYOU were replaced inline.
  4. The "variable_get('forward_flood_control')" was missing.
  5. Added the missing t('...').

Could anyone review this patch ? Thanks ;-)

CommentFileSizeAuthor
forward_several_issues.patch7.32 KBMoxide

Comments

seanr’s picture

Status: Needs review » Reviewed & tested by the community

These all look good. As soon as I get my CVS set up again (new computer), I'll apply the patch. Thanks.

seanr’s picture

Status: Reviewed & tested by the community » Fixed

This patch has been applied to the 4.6 version. Thank you for your assistance.

Moxide’s picture

You're welcome !

Anonymous’s picture

Status: Fixed » Closed (fixed)