Implement "Internal site search tracking"

Great feature!
Has anyone got it working with custom_search module? It uses another url like
h**p://example.com/?q=search/node/my%20search%20pattern

But sadly it does not. I tried both "query" and "node" as search parameter with "search" as search-url. However piwik doesn't find any.

To get any results I had to modify SiteSearchs SiteSearch.php:

public function logResults($notification) {
  // ...
			$actionUrl = $action->getActionUrl();
			$actionName = $action->getActionName();
			if (substr($actionUrl, 0, strlen($url)) == $url) {
				Piwik_SiteSearch_Archive::logAction(array(
					'idaction' => ($idaction),
					'name' => $actionName // instead of $actionUrl because only at the actions name we an url like "search?query=cherry"
				), $site['idsite'], $site, $resultCount);
				
			}
		}
}

Oddly I got no search tracking though.

After further debugging it looks as the problem occurs because piwik SiteSearch plugin misses the "data" parameter:

plugins/SiteSearch/SiteSearch.php

public function logResults($notification) {
		$action = $notification->getNotificationObject();
		$idaction = $action->getIdActionUrl();

		// search results
		$data = Piwik_Common::getRequestVar('data', '');
		$data = html_entity_decode($data);
		$data = json_decode($data, true); // empty!

		$resultCount = false; // simulating 5 results by setting $resultCount = 5; works pretty fine!
		if (isset($data['SiteSearch_Results'])) {
			$resultCount = intval($data['SiteSearch_Results']);
		}
		// ...
}

In further processing this happens:
plugins/SiteSearch/Db.php

	public static function replaceBinding(&$matches) {
		$name = $matches[0];
		$newBinding = false;
		if (isset(self::$bindings[':'.$name])) {
			$newBinding = self::$bindings[':'.$name];
		} else if (isset(self::$bindings[$name])) {
			$newBinding = self::$bindings[$name];
		}
		if (!$newBinding) { // $newBinding = false/0
			throw new Exception('Invalid binding name "'.$name.'"');
		}
		
		self::$newBindings[] = $newBinding;
		return '?';
	}

I'm wondering how the plugin wants to track search terms without any results since $resultCount will be 0 and the same expeption will be thrown.

I created an issue on github: https://github.com/BeezyT/piwik-sitesearch/issues/issue/26
Hope we get it working ;)

No, sadly I didn't find any solution yet. This is still an interesting feature, but I've got no free ressources to dive deeper here atm. If I find a solution I will share it here, of course!

Were you able to reproduce the issue?