Allow admin to set the node notify default
| Project: | Comment Notify |
| Version: | 5.x-2.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (to be ported) |
Hello everyone,
Great to have a light module that can be sued instead of the full message framework.
I want all users to have notifications from their own content (I only allow users to create blogs and forum threads) on as default so that they can receive comments from the blogs and forum threads they have initiated. I do not see that in the default options on the admin menu. I decided to change the database and make the default 1 there (I double chekced that it was still default) but when I create an user the user still gets that function off as default. not sure if I am doing something wrong? (first time I change a default on a database so I might be missing something obvious)
any idea on what I can do to change this behaviour?
Any help is greatly appreciated.
#1
This is not possible now, so I'm marking it a feature request.
I'm not sure we should provide this because it further complicates the user interface.
#2
I agree on the feature request. Or at least, enable the "main switch" in the profile view when a user enables notification on a comment. Apparently, today its possible to select notification when posting a comment, without getting any - until you enable comment notification in the user profile. At minimum this is a usability issue.
Oh - thanks for the comment notify module by the way :)
Bjarne
#3
If that is the case it's a bug. I will try to test that specifically, but if you could post a "simplified, repeatable test case" it would be very helpful.
#4
I'd also like to see this so new users are automatically notified of content they create.
@totocol is this the line you changed from FALSE to TRUE?
'#default_value' => isset($edit['node_notify_mailalert']) ? $edit['node_notify_mailalert'] : FALSE,#5
I too am very interested in this feature.
I need it on a site right now so I've done:
Changed comment_notify.module line 291 to:
<?php'#default_value' => isset($edit['node_notify_mailalert']) ? $edit['node_notify_mailalert'] : 1,
?>
Changed comment_notify.module line 375 to:
<?phpif (((!empty($author->node_notify_mailalert) && $author->node_notify_mailalert == 1) || empty($author->node_notify_mailalert)) && $user->mail != $author->mail) {
?>
But there definitely needs to be an admin option to set this as default on or off that would control these lines. A little busy right now but I will work up a proper patch for review when I get a chance.
#6
Hi,
+1
I agree that this option would be great.
Thanks.
#7
+100
This is definitely needed. It doesn't make sense for a admin to be able to set a "Default state for the notification selection box for registered users." if it doesn't send them by default.
#8
subscribing
#9
Here the patch I've made for this problem. It's so simple, I don't understand why somebody else didn't already make it by now.
#10
It seems that is now time to learn how to apply a patch ! Thank you so much !
Just two questions, does your patch also enables comment notification of comments made by the user ?
And do you know a way to enable comment notification (for posts) of all previous posts made by users before I use this patch ?
Thanks again.
#11
This patch adds a checkbox to the Comment Notify admin settings page that lets you specify the default for new users. See screenshot attached.
#12
Thanks so much buddy! This works great!
#13
Any idea to enable comment notify for all previously created users ?
Thanks.
#14
@wwwoliondorcom - http://drupal.org/node/252697
@darktygur - thanks, I'll try to review this and commit it soon.
#15
Thank you, but I was speaking about comment notification for node creation.
I mean, all the people who previously posted a node on the website, i would like that they get notification of new messages on their node.
Possible ?
#17
@Greggles - Any chance you will have time to review this soon?
#18
Thanks @darkTyger - now fixed http://drupal.org/cvs?commit=277488
@Elijah Lynn - asking me to review something usually makes me less likely to review. Providing your own review (which you did, but not in a detailed way) or providing simpletests for the code is likely to make me commit it.