Closed (won't fix)
Project:
Read More Link (Drupal 6 and earlier)
Version:
6.x-5.0-rc7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Mar 2009 at 08:05 UTC
Updated:
17 Nov 2010 at 09:13 UTC
Jump to comment: Most recent file
Comments
Comment #1
gorlov commentedDiscovered the same problem, with only relative links in RSS links that break once in Feedburner feeds.
This was first identified in http://drupal.org/node/294744, then fixed as described in http://drupal.org/node/294846, but then "re-broken" in 6.x-3.0 release.
Comment #2
todd nienkerk commentedThe RSS feeds need to be fixed to use absolute paths.
Comment #3
todd nienkerk commentedPlease try the latest 6.x-3.x-dev release. I'm pretty sure this is already fixed.
Comment #4
gorlov commentedI am 6.x-3.x-dev (the latest as of March 24, 2009). As a result, I had to disable ed_readmore from the two sites on which I had it installed. The Feedburner feed, and the emailed newsletters, had the readmore links as relative links, so they would point to feedburner.com/drupalsite_relative_link.
Comment #5
todd nienkerk commentedI discovered a fundamental limitation of the node system that prevents a clean separation between a normal teaser and an RSS item. The
$op(operations) path progresses like this: (1) load > (2) view > (3) alter > (4) rss item. Because "rss item" occurs after "view," the link has already been added to the node object.To bypass this entirely, I am switching from the hook_nodeapi() to template_preprocess_node() method of appending the link to the end of the node teaser.
This means that the "read more" link will not be able to add a link to RSS items But that's okay -- Drupal already adds a "read more" link in node.module (see node_feed()). Unfortunately, Drupal's default "read more" link cannot be themed or altered.
I have filed a feature request for Drupal 7 to expose the default "read more" link in RSS items to alteration: #431660: Expose "read more" link in RSS feeds to a configuration UI or preprocess function.
Because the Read More module cannot completely tap into the RSS item's "read more" link, I am marking this "won't fix." I will commit my changes regarding the hook_nodeapi() to template_preprocess_node() switch in a few minutes.
Comment #6
zyxware commentedHere is a patch that will give the user the option to use absolute URLs for the read more links. The patch will add an admin setting for the module that will allow the user to enable/disable use of absolute URLs for the read more link.
Comment #7
sachbearbeiter commentedthere is an won't fix together with this patch by zyxware ...
is there a problem with the patch or is it already in dev?