Is the 'Generated password' message actually needed? Maybe for admins, or roles with administer users permissions, but I can't see why anonymous users have to see this. Why not throw a if(user_access('administer users')) around it?

CommentFileSizeAuthor
#7 patch_commit_39eb94029419.patch3.1 KBLukas von Blarer
#6 remove_pawword_msg-405774-5.patch1.13 KByogesh1110
#5 remove_pawword_msg-405774-5.patch1.13 KByogesh1110
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

japanitrat’s picture

japanitrat CreditAttribution: japanitrat commented

hm i guess we had this for testing purposes on both forms (registration / admin user-add). You're right, its not needed on the regular registration form. On the other hand, it makes sense if the admin selected "optional password" instead of "no password fields". So maybe the messages should be more descriptive for normal user registrations.

my proposals for regular user registration forms:

  1. "optional password": You did not enter a password, so we generated one for you. (maybe the generated one could also displayed here, since activation is needed anyway in most cases)
  2. "no password fields": either no message at all, or the password like above.

The password display option could also be configurable in the settings.

yingtho’s picture

yingtho CreditAttribution: yingtho commented

I agree with the proposal.

joelstein’s picture

joelstein CreditAttribution: joelstein commented
Status: Active » Fixed

The UI was cleaned up a bit in this ticket #772690: Module revamp and the latest release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yogesh1110’s picture

yogesh1110 CreditAttribution: yogesh1110 commented
FileSize
remove_pawword_msg-405774-5.patch1.13 KB

Here is the patch to display password message based on permission 'administer users'

yogesh1110’s picture

yogesh1110 CreditAttribution: yogesh1110 commented
Status: Closed (fixed) » Patch (to be ported)
FileSize
remove_pawword_msg-405774-5.patch1.13 KB

Here is the patch to display password message based on permission 'administer users'

Lukas von Blarer’s picture

Lukas von Blarer
he/him
CreditAttribution: Lukas von Blarer commented
FileSize
patch_commit_39eb94029419.patch3.1 KB

I wrote a patch for D7 that adds a option to disable these messages globally.

joelstein’s picture

joelstein CreditAttribution: joelstein commented
Status: Patch (to be ported) » Fixed

Thanks for these ideas. I added this functionality as a configurable option on the settings page (for both D6 & D7). You can set it to hide the passwords, show only when admins are creating accounts, show only when users are creating their own accounts, or both.

D7: http://drupalcode.org/project/genpass.git/commit/7db2748
D6: http://drupalcode.org/project/genpass.git/commit/a2e7714

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.