Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
forum.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2005 at 19:02 UTC
Updated:
12 Jun 2009 at 14:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
Wesley Tanaka commentedComment #2
Wesley Tanaka commentedre-rolled for test2
Comment #3
Thox commentedI'm not keen on the way you have changed the arrays ($forum_topic_list_header and $rows). I'd be happier doing something like this:
Also, there should be an extra check than simply if the module exists. View counts are optional so you should check that they're on too.
Comment #4
Wesley Tanaka commentedI'm confused about the intentions behind your sample code -- it appears to add "Last Reply" twice.
Comment #5
Wesley Tanaka commentedthox clarified the comment here: http://drupal.org/node/40580#comment-60927
on irc.
Comment #6
drummThis is not critical.
Comment #7
dries commentedNot sure, but we might want to check whether the user is allowed to view the stats. The statistics.module has some permissions that might be relevant.
Comment #8
pwolanin commentedYes, the statistics module has a permission 'view post access counter'. I currently have this off for authenticated users since our site is mostly informational rather than interactive (at the moment- still trying to entice the membership that gets postal mailings and comes to meetings to join into the online community).
Comment #9
beginner commentedDoes this mean the patch needs work?
Comment #10
pwolanin commentedYes needs permission checking and probably some updating for HEAD.
Also, it may require more significant reworking of a CCK type replaces the 'forum' type: http://drupal.org/node/62340
Comment #11
liam mcdermott commentedBumping version.
Comment #12
Gurpartap Singh commentedjust enable the statistics module + proper permission to stats access to get the views column.