Closed (fixed)
Project:
ImageField Tokens
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
19 Mar 2009 at 04:52 UTC
Updated:
19 Mar 2009 at 07:24 UTC
Whay not contribute a patch to imagefield instead of forking.
Comments
Comment #1
dnewkerk commentedAgreed... this is a feature I'd love to see in Imagefield, but it should be added to Imagefield, not a separate module. Thanks for contributing this feature... can we figure out how to make it into a patch for Imagefield instead?
Comment #2
quicksketchOr at least maybe just a better name. "ImageField+" sounds like an ImageField fork with better features. I was about to go off the deep end when I saw this. Perhaps ImageField Tokens would be a better name.
I have to agree that I wouldn't necessary want node-level tokens in ImageField directly, they're difficult to work with on the node level since they're not yet available when creating a new node.
Comment #3
dnewkerk commentedGood point... so maybe as a separate module is fine, so those who want it can use it, and those who don't can skip it. Should have a different name definitely though. I was initially confused too, thinking it was a full fork of Imagefield, just to add some extra features.
Comment #4
nevets commentedI am wondering about this, "I have to agree that I wouldn't necessary want node-level tokens in ImageField directly, they're difficult to work with on the node level since they're not yet available when creating a new node."
Since tokens are generally replaced on output (that is the saved string contains the token which is replaced when the node is viewed) I do not see this as an issue.
Comment #5
decipheredYes, this is a separate module, not a fork, out of necessity.
I choose the name because I liked the sound of it, I wanted something that tied it to ImageField but showed that it added new functionality. Clearly the naming I choose was too confusing, and if there ever was a time to change it, it would be now. If you have any suggestions, let me know.
"ImageField extras" - Doesn't really roll off the tongue.
"ImageField Node Tokens" - ditto...
Comment #6
decipheredRenamed to ImageField Tokens to reduce confusion.
Comment #7
dww