Handle comments like nodes? (and some bugs) [#407080]

Some stuff still seems to be wrong with the answer/edit link generation while the permission themselves are working:

Users which have the "edit own forum topics" permission or the "EDIT" permission don't see a edit button for their own topics although they can edit when typing the node/xx/edit URL.
you always see an "edit" link for your own comments, even if "edit posts" and "post in this forum" has been removed for this role, and you can indeed edit those comments
When the global "edit own posts" permission is removed also, you cannot edit your own comments, but the "edit" link inside every of your own comments is still there
if you have no post permission for a forum, the inline answer form disapears, but in every comment there is still the "answer" link (which will not work)

Comments

Comment #1

salvis

he/his

commented 19 March 2009 at 23:21

Thank you for the feedback! I'll look into each item in detail, but let's discuss this first:

I think the intention of the comment.module is to let all comment authors edit their own comments as long as no one has replied to them. Is this desired behavior for forum comments?

Comment #2

Frank Steiner commented 20 March 2009 at 09:40

You are referring to point 2. Hmm. I feel that topics (nodes) and comments should behave somewhat similar. I.e., if I'm NOT able to edit my own post as long as it doesn't have a reply, because "edit posts" has been set off for a forum, then I should also not be able to edit my own comments.

I thought that because you named it "edit posts" it would apply to both, nodes and its comments. So I vote for handling permissions for nodes and comments the same way. Whatever you allow or disallow for a certain forum, should apply to both.

Comment #3

salvis

he/his

commented 21 March 2009 at 18:03

Title:

Link generation still wrong with beta3

» Handle comments like nodes? (and some bugs)

Actually to points 2 and 3.

The edit own forum topic permission applies only to nodes, not to comments. Comments have their own mechanism as mentioned above, which is completely different. I'm sure there are people who'd prefer that comments keep working the same everywhere on the site. It may or may not be possible to get them to work like nodes if they're under FA control — that would provide uniform behavior in forums, at that cost of breaking a different uniformity.

merlinofchaos was the original author of FA and he named it "edit posts", so it wasn't my choice, but FA's complexity has increased quite a bit recently, and I definitely don't want to split node and comment configuration.

Heck, it might even be possible to get the edit own forum topic permission to apply to comments within forums, but is that desirable?

Anyone else have an opinion on this topic?

Comment #4

salvis

he/his

commented 22 March 2009 at 17:58

Title:

Handle comments like nodes? (and some bugs)

» Link generation still wrong with beta3

Users which have the "edit own forum topics" permission or the "EDIT" permission don't see a edit button for their own topics although they can edit when typing the node/xx/edit URL.

I can't reproduce this. I don't have "edit buttons" though, but just humble Edit links; those are there, either with the edit own forum topics permission or the Edit grant. Could this be a theming issue?

you always see an "edit" link for your own comments, even if "edit posts" and "post in this forum" has been removed for this role, and you can indeed edit those comments

As mentioned before, this is the core comment.module behavior. The "edit" links go away as soon as there's a reply. I hesitate to change this without getting more votes in favor of such a change.

When the global "edit own posts" permission is removed also, you cannot edit your own comments, but the "edit" link inside every of your own comments is still there

I can't reproduce this. edit own forum topics does not affect editing of comments. Please clarify this.

if you have no post permission for a forum, the inline answer form disapears, but in every comment there is still the "answer" link (which will not work)

This is fixed in the new -dev snapshot (give it up to 12h to be repackaged).

Comment #5

salvis

he/his

commented 22 March 2009 at 17:59

Title:

Link generation still wrong with beta3

» Handle comments like nodes? (and some bugs)

Comment #6

Frank Steiner commented 23 March 2009 at 09:13

"Buttons" are just the links styled as buttons :-) Indeed I still don't see any "edit" link inside a nodes (topic) body, but I'm not even sure if it should be there or just as tab next to the "view" tab like for normal pages? I just don't find the place where the edit link would be created, neither in the forum nor in the FA module, so I'm a it confused about point 1 currently :-)

Point 2: agreed! I misunderstood that you had changed the comment handling in beta3 and not only the link permissions. I'm fine with the way it is now!

And point 3 turned out to be a interaction between your new and my old way of handling the links, I hadn't removed all of my own stuff before testing beta 3 :-)

Comment #7

salvis

he/his

commented 23 March 2009 at 20:28

just as tab next to the "view" tab like for normal pages?

Yes, that's it. They don't look so much like tabs in Garland, but in bluemarine they do. So do you have them?

Comment #8

Frank Steiner commented 23 March 2009 at 22:08

Yes, that was my own confusion, because our theme has no tabs at all and so I had put the Links/Buttons into the node body, just like the comments have it. And I was so used to it that I thought they were standard :-) I think I took this feature from the Advanced Forum module if I remember correctly.