Default permissions are not saved for newly created forums

Yes, I see this, thank you for your report.

Please locate line 530 in forum_access.admin.inc that looks like

$is_changed = FALSE;

and replace it with

$is_changed = strpos($_GET['q'], 'admin/content/forum/add/') === 0;

Then delete and recreate any newly created forums. Let us know what you find.

I've committed an improved version of this patch (which does not trigger a permissions-need-rebuilding message) to the -dev version. Give it up to 12h to be repackaged.

To fix newly create forum either delete and recreate them (if there are no posts yet), or change the Forum Access settings and save.

Thanks!

I am using the March 22 DEV snapshot, and I am seeing the same thing.

I deleted all my forums, recreated them and then tried to set the permissions for each role. It says it saves the ACL, but if I go back into edit a forum, all the permissions are gone.

@dbrum: Please check the second line in your forum_access.admin.inc file. It should read

// $Id: forum_access.admin.inc,v 1.15 2009/03/22 17:52:17 salvis Exp $

Does it?

Please don't bring in ACL in this context. Unless you define moderators, the ACL companion module does not come into play. Please cut&paste the message that you're seeing.

Check the {forum_access} database table to see whether records with the tid of your forum have been written.

Salvis, I'm a total Drupal noob, so please bear with me.

I am not sure I understand what you want me to do. Do I need to edit the forum_access.admin.inc to have the line you indicated in it as the second line?

Salvis - I just checked that file, line #2 has:

// $Id: forum_access.admin.inc,v 1.15 2009/03/22 17:52:17 salvis Exp $

Salvis, I just checked the forum_access table, and after setting the access rules for forum_access, there are 0 rows:

Row Statistics:
Statements Value
Format fixed
Rows 0
Creation Mar 20, 2009 at 06:43 PM
Last update Mar 23, 2009 at 06:54 AM

Can anyone else confirm or deny seeing this with the current -dev version?

You haven't by any chance kept BETA3 around in some other directory, have you?

When you click the [Save] button, what message do you get at the top of the next page? Please cut and paste the exact message.

I'm assuming your saving with the default View and Post for the authenticated user set, right? Have you tried turning ON some other checkboxes?

I removed the older module completely, and added the new DEV snapshot from scratch.

I created a new Role and want anonymous access on this forum also - see shot below:

http://i263.photobucket.com/albums/ii137/dbrum101/forum-1.jpg

When i save the changes:

* The forum General Info/FAQ and Open Topics has been updated.
* The content access permissions have been updated.

See shot: http://i263.photobucket.com/albums/ii137/dbrum101/forum-2.jpg

This is on a new forum just created for testing. Imemdiately upon saving I go back to the Edit Forum link, and none of the permissions are checked.

Ok, seems like we have to do this the hard way...

Please locate the following code in forum_access.admin.inc (around line 560):

  foreach ($access['view'] as $rid => $checked) {
    if (!empty($form['forum_access']['view'][$tid]['#disabled'])) {
      continue;
    }
    $grants[] = array(
      'realm' => 'forum_access',
      'gid' => $rid,
      'grant_view' => (bool) $checked,
      'grant_update' => !empty($access['update'][$rid]),
      'grant_delete' => !empty($access['delete'][$rid]),
      'priority' => $fa_priority,
    );
    db_query("INSERT INTO {forum_access} (tid, rid, grant_view, grant_update, grant_delete, grant_create, priority) VALUES (%d, %d, %d, %d, %d, %d, %d)", $form_state['values']['tid'], $rid, (bool) $checked, !empty($access['update'][$rid]), !empty($access['delete'][$rid]), !empty($access['create'][$rid]), $fa_priority);
  }

Add three lines so that it looks like the following:

  drupal_set_message('About to save {forum_access} records...');            //NEW
  foreach ($access['view'] as $rid => $checked) {
    if (!empty($form['forum_access']['view'][$tid]['#disabled'])) {
      continue;
    }
    $grants[] = array(
      'realm' => 'forum_access',
      'gid' => $rid,
      'grant_view' => (bool) $checked,
      'grant_update' => !empty($access['update'][$rid]),
      'grant_delete' => !empty($access['delete'][$rid]),
      'priority' => $fa_priority,
    );
    $result =                                                               //NEW
    db_query("INSERT INTO {forum_access} (tid, rid, grant_view, grant_update, grant_delete, grant_create, priority) VALUES (%d, %d, %d, %d, %d, %d, %d)", $form_state['values']['tid'], $rid, (bool) $checked, !empty($access['update'][$rid]), !empty($access['delete'][$rid]), !empty($access['create'][$rid]), $fa_priority);
    drupal_set_message("gid = $rid: ". ($result !== FALSE));                //NEW
  }

You should then see something like:

* The forum ForumName has been updated.
* About to save {forum_access} records...
* gid = 2: 1
* gid = 4: 1
* gid = 16: 1
* The content access permissions have been updated.

Please post the resulting screenshot.

Salvis - the code is not spitting out anything. Just to be sure the script was being called properly - I messed up the file and put in bad syntax and sure enough when I went into the admin page it complained about a bad PHP file. So I put in your code again, and it does not ever reach those lines. I tried putting in my own simple file logging as follows right after that call, and it doesn't get to it:

$myFile = 'output.txt';
$fh = fopen($myFile, 'w') or die("can't open file");
$stringData = $result;
fwrite($fh, $stringData);
fclose($fh);

Again - no output file with the message is logged. I am not sure where or how, but this script does not ever reach the lines of code that insert into the DB.

Well, put a

drupal_set_message('TEST');

at the top of the _forum_access_form_submit() function; or alternatively comment out the entire function and ask yourself what's happening. I'm not really surprised that you're not executing the current code.

I removed the older module completely

Obviously not. Remove Drupal completely (including the database) and start from scratch. Don't ever copy/move/rename obsolete files/directories around inside the Drupal code tree. Always DELETE them.

I'm a total Drupal noob, so please bear with me.

You're wasting my time. You should not start downloading BETA versions until you know what you're doing...

Salvis - I think you are a total arrogant SOB and it's people like you who give open source and development a bad name.

A big fuck off to you mon ami.

@dbrum: This is a BETA test of a highly technical module, which is long overdue. If you participate in a beta test, you are expected to help solve problems, not to introduce additional self-made ones.

I'm a developer, not a hand-holder, and I am doing this in my spare time, with no recompense at all. My issues queues prove that I am patient and supportive, but there are limits.

Open source means that everyone can participate and that they educate themselves to the point where they can actually contribute and give something back to the community.

You seem to think that open source means that people should work for you for free — you're way out of line.

Hi salvis!

Thank you for the module. Here's my issue, hopefully you'll help me to resolve it.

1. After the latest update (to 6.x-1.0-beta3) permissions were rewritten and now all my users have full access to all nodes and all comments in all forums I've created before.
2. I tried to fix that by playing with permissions in access control container of each forum.
3. Only two boxes of all checked are available to play with. (see attach1). And there's one unchecked box for most powerful role (groundsman) - it's strange because I've checked it while using previous beta.
4. I unchecked authenticated user boxes, set groundsmans' one to 'on' and clicked 'Save'.
5. 'The content access permissions have been updated.' drupal message appeared.
6. I opened that forum on editing and... saw the same pic (see attach1).

Since then:
1. I fully uninstalled Forum Access 6.x-1.0-beta3 (with /admin/build/modules/uninstall) and ACL too, deleted all the FA files, copied new -dev, installed it from scratch and saw the same old pic (see attach1). There's still no effect after every combination of boxes I've set (I tried grant view, post, edit, delete for almost all roles I have) were "saved" (see #13 - there's the same signs I've seen).
2. I checked the second line in my forum_access.admin.inc file (yes, there's "// $Id: forum_access.admin.inc,v 1.15 2009/03/22 17:52:17 salvis Exp $" string).
3. I checked my {forum_access} table. "SELECT * FROM forum_access" returns no rows either before or after grants updating operation.
4. There's definitely no beta3 files nowhere near my drupal installation tree.
5. I added three lines you had mentioned in #14 and here's the result attached (see attach2) where the first one is "The forum Общие моменты has been updated".

Have no thoughts what to do next. Please show me the way, o Virgil -))
Thanks in advance.

Since you're seeing the 'About to save {forum_access} records...' message, your case is not the same as dbrum's, who said he didn't see any additional output. I wish you had opened a new issue...

Thank you for providing ample details. I finally see the bug. Please change

    if (!empty($form['forum_access']['view'][$tid]['#disabled'])) {

to

    if (!empty($form['forum_access']['view'][$rid]['#disabled'])) {

(tid to rid) in the code near the top of the lines posted in #14. Let us know if this helps.

>> Since you're seeing the 'About to save {forum_access} records...' message, your case is not the same as dbrum's, who said he didn't see any additional output.
Hmmm. Fair enough. I didn't catch that difference.

>> I wish you had opened a new issue...
I'm sorry Salvis I was wrong to post my issue here but I really thought there's the same one. Is it still necessary to open a new issue?

>> Please change ... Let us know if this helps.
Thank you Salvis. I changed the line you've mentioned, checked and unchecked some permissions and saved the result.
1. New drupal message appeared (see attach);
2. Permissions were _actually_ saved;
3. {forum_access} contains new lines;
4. There're correct values on 'Edit forum' page;
5. DNA blocks (both main and additional) display correct values for each role and user;
6. User without granted permission to view the forum doesn't see that.
It really works as it should do! Thank you very much!

Thank you for testing and reporting back. The screenshot looks as it should now (depending on your data, of course). I'm glad everything works now!

>> Is it still necessary to open a new issue?

No, never mind, thanks.

I'll post BETA4 shortly, probably tomorrow.