Download & Extend
Issues

"Parsed JavaScript file" message clogs up watchdog

Posted by mrfelton on March 21, 2009 at 10:02pm
Project:Drupal core
Version:6.x-dev
Component:locale.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

My watchdog is filled with messages about locale.module parsing javascript files. This message is printed so many times that it makes the watchdog a pretty useless tool for analysing problems with the site as there may only be 3 or 4 valid watchdog message in a page full of these messages from locale. The problem was recently reported on the forum here http://drupal.org/node/402268 and I brought it up in IRC and was advised to open a bug report.

Is this really intended behaviour? Or is this just a stray watchdog call that was forgotten to be removed? If it really is a genuine message, then there needs to be a way to turn down the logging level so that the watchdog can become useful to anyone who cares about things other than local.module pasing javascript files.

Login or register to post comments

Comments

#1

Posted by kruser on June 4, 2009 at 12:59pm
Version:6.10» 6.12

I'm getting these notices too for every javascript file...
Parsed JavaScript file sites/all/modules/memcache/memcache_admin/memcache.js.

Any idea how to get rid of them?

#2

Posted by mrfelton on June 4, 2009 at 6:14pm

yeah, comment out the line in local.module - line 508. Yes, It's a core hack, but there's no other way as far as I know.

#3

Posted by kruser on June 4, 2009 at 7:03pm

Good to know. Thanks!

#4

Posted by pvhee on July 2, 2009 at 8:56pm

Still no solution for this problem?

#5

Posted by ShannonK on July 30, 2009 at 7:15pm

I'm getting a bunch of these messages too. What do they mean? Is this an error?

AttachmentSizeStatusTest resultOperations
parsed_javascript.png45.58 KBIgnored: Check issue status.NoneNone
parsed_javascript2.png19.17 KBIgnored: Check issue status.NoneNone

#6

Posted by malukalu on September 2, 2009 at 5:37pm

subscribing

#7

Posted by mrfelton on September 25, 2009 at 4:51pm
Version:6.12» 6.14
Status:active» needs review

Here is a patch that removes the annoying message. Can we get this commited into core? The watchdog is next to useless when it's full of these messages.

AttachmentSizeStatusTest resultOperations
locale-watchdog.patch595 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch locale-watchdog.patch.View details

#8

Posted by lsabug on October 21, 2009 at 4:00pm

Subscribing to track fix.

#9

Posted by axel.rutz on October 24, 2009 at 11:56pm

subscribing

#10

Posted by greggles on December 2, 2009 at 5:49pm

This seems reasonable to me as well. I found this issue from a thread that claimed that Google Analytics caused this to be parsed on every page, but the site where I have this problem doesn't use Google Analytics. Perhaps there are other modules that cause it to happen more often than necessary, but I'm not sure watchdogging all the time is the solution.

#11

Posted by abqaria on December 21, 2009 at 4:17pm

subscribe

#12

Posted by mlncn on December 28, 2009 at 5:18am
Version:6.14» 6.x-dev
Status:needs review» reviewed & tested by the community

Unless someone can explain why we care when a JS file is parsed, or more likely why locale shouldn't be parsing JavaScript files in the first place, can we call this patch ready to go? We've tested it.

benjamin, agaric

#13

Posted by Dave Reid on December 29, 2009 at 4:23am
Version:6.x-dev» 7.x-dev
Status:reviewed & tested by the community» needs work

Yeah, this message is unnecessary. Let's fix in D7 first.

#14

Posted by Ela on January 14, 2010 at 3:02am

subscribe

#15

Posted by Bob3009 on February 8, 2010 at 4:35pm

subscribe

#16

Posted by greggles on February 18, 2010 at 8:29pm
Status:needs work» needs review

Ok, same thing for D7.

AttachmentSizeStatusTest resultOperations
409676_locale_watchdog_unnecessary.patch1.68 KBIdlePASSED: [[SimpleTest]]: [MySQL] 17,903 pass(es).View details

#17

Posted by Dave Reid on February 18, 2010 at 8:44pm
Status:needs review» reviewed & tested by the community

Yay!

#18

Posted by Dries on February 19, 2010 at 10:38am
Version:7.x-dev» 6.x-dev

Committed to CVS HEAD. Moving to D6.

#19

Posted by greggles on February 19, 2010 at 12:27pm

Now the patch from #7 should be good - http://drupal.org/node/409676#comment-2082670

#20

Posted by Sten on February 24, 2010 at 4:24pm

Sorry i am confused is the patch for D6 on #7 ? it says its failed and has not been retested. Or is it greggles post on #16 confused as he put D7

Can someone clarify for me,

Thx

#21

Posted by greggles on February 24, 2010 at 4:38pm

The patch in #7 applies to Drupal 6. The failure message is about testing it on Drupal 7, where we expect it to fail.

#22

Posted by Gábor Hojtsy on March 1, 2010 at 9:31am
Status:reviewed & tested by the community» fixed

Theoretically, this should not happen often, but only when caches are cleared. I'd advise you look at why are your caches cleared this often.

Committed this patch to Drupal 6 too.

#23

Posted by System Message on March 15, 2010 at 9:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here