When I am creating a new ticket and untick the Subscribe checkbox, it gets ticked again after clicking the [ Preview ] button.

Comments

jeremy’s picture

jeremy commented
Status: Active » Fixed

Fix committed. Thanks for all the thorough testing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

roball’s picture

roball commented
Status: Closed (fixed) » Active

Hm, just tested JobTrack 6.x-1.x-dev (2009-Apr-24) and now the Subscribe checkbox gets unticked every time after clicking the [ Preview ] button, even if it was checked before (which is the default).

jeremy’s picture

jeremy commented
Status: Active » Fixed

I'm unable to duplicate this with the latest code.

jeremy’s picture

jeremy commented
Status: Fixed » Active

Ah, it seems to depend on which permissions are enabled. As a user with limited jobtrack permissions I couldn't duplicate. But as an admin I am able to duplicate. Re-opening.

jeremy’s picture

jeremy commented
Status: Active » Fixed

Fix committed. There was an extra line of code that wasn't supposed to be there which was breaking things.

roball’s picture

roball commented
Status: Fixed » Active

I'm sorry, but this still does not work as expected with the latest CVS version. I just tested to create a new ticket as jobtrack admin (thus, with full rights).

The two checkboxes in the Notifications section default to

[+] Subscribe
[ ] Suppress notification

When I untick the Subscribe checkbox, it gets ticked again after clicking the [ Preview ] button. When I only tick the Suppress notification checkbox, the Subscribe checkbox also gets ticked after clicking the [ Preview ] button.

jeremy’s picture

jeremy commented
Status: Active » Fixed

It seems you downloaded an older tarball -- I have confirmed that this works in the latest code. Please grab the latest code from CVS and try again. (You can confirm you have a new enough version by looking in the CHANGELOG.txt file.)

roball’s picture

roball commented
Status: Fixed » Active

This really happens with the latest 6.x-1.x-dev (2009-May-20) version:

[root@anet ~]# head /var/www/drupal-6.12/sites/all/modules/jobtrack/CHANGELOG.txt
May 19th, 2009
 - jobtrack.module
    o bug #449020: properly support mime encoded mail subjects
    o feature #446318: introduce 'hide ticket status bar' permission which
      allows State, Priority, Client and Assigned menus to be hidden from user
    o bug #455238: if a user has 'edit any ticket' or 'delete any ticket'
      permissions, ignore the 'only view own tickets' permission
    o bug #457306: don't display other user's tickets on "user's latest tickets"
      page
    o bug #420540: preserve subscribe status when ticket is previewed
jeremy’s picture

jeremy commented
Status: Active » Postponed (maintainer needs more info)

What jobtrack permissions does your user have? I'm unable to duplicate.

roball’s picture

roball commented 
        access (CLIENT) tickets                    [+]
        administer jobtrack                        [+]
        administer state                           [+]
        can assign tickets to other users          [+]
        can subscribe other users to notifications [+]
        can suppress notification                  [+]
        create tickets                             [+]
        delete any ticket                          [+]
        delete own tickets                         [+]
        download mail via jobtrack/fetch           [ ]
        edit any ticket                            [+]
        edit own tickets                           [+]
        hide ticket status bar                     [ ]
        only view own tickets                      [ ]
jeremy’s picture

jeremy commented
Status: Postponed (maintainer needs more info) » Fixed

It seems I read your report backwards, I am now able to duplicate. I have committed a fix. This fix will be in the upcoming 1.6-rc2 and beyond. Thanks for all of your testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

roball’s picture

roball commented
Project: Jobtrack » Support Ticketing System
Version: 6.x-1.x-dev » 6.x-1.0-rc1

Confirmed to work fine in Support 6.x-1.0-rc1.

Thank you Jerermy!