The i18n_menu module attempts to use hook_form_alter() to modify the form that the menu module is rendering, if the module when installed doesn't set its weight in the system table then there is no guarantee that the module will execute properly, because the menu module hook could be called after the i18nmenu thus making the form_alter hook invalid due to the data being modified is just going to be overwritten in the defaults when the core menu module hook_form_alter gets called.

Comments

jdubbwya’s picture

jdubbwya commented

Here is a better explanation. The weight of the i18nmenu module is 0 in the system table which is the same as the menu menu module. Thus when the hook_form_alter is called there is no reliable way to ensure that i18nmenu is called after the menu module meaning the form array created by the i18nmenu will just be overwritten by the defaults in the menu module whenever the drupal api function module_implements returns the menu module after the i18nmenu module, and with a weight unless the system table has a weight of 1 for i18nmenu which will always ensure that when hooks are called the i18nmenu module will execute after the standard menu module

jose reyero’s picture

jose reyero commented
Category: bug » support
Status: Active » Fixed

Are you talking about a real bug or about a theoretical issue?

The modules are ordered by weight, filename. So for the same weights, all modules in 'modules/*' (core) go before all modules in 'sites/*'' (contrib)

jdubbwya’s picture

jdubbwya commented

This is not a theoretical issue, I have found this issue to be true in two or three different instances I use at my office.

jose reyero’s picture

jose reyero commented
Category: support » bug
Priority: Critical » Normal
Status: Fixed » Active

Ok, then let's open it again, I just didn't know from the description.

Then is the location of your core modules modules/* and contrib modules sites/* or are you using any non standard layout?

bspellmeyer’s picture

bspellmeyer commented

Currently for existing translated nodes the i18nmenu module overwrites the #default_values set by the menu module. Thus on every node edit the menu title, parent item and weight have to be manually reselected in the node edit form.

Setting the weight of the i18nmenu module to -1 in the system table resolves this issue.

I am using Drupal 6.11 / i18n 1.0 and the standard directory layout (sites/all/modules/contrib/i18n).

bspellmeyer’s picture

bspellmeyer commented
Status: Active » Closed (duplicate)

This is actually a duplicate of
http://drupal.org/node/364375