Closed (fixed)
Project:
Deploy - Content Staging
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Apr 2009 at 23:34 UTC
Updated:
23 Apr 2009 at 14:50 UTC
Deploy module looks terrific ! Thanks Greg.
A couple minor remarks regarding the use of batch API :
- Your batch ops (deploy_plan_check_item_batch, deploy_item_batch) don't take tha batch $context as an argument, thus $context['message'] = t('Now processing %item', array('%item' => $description)); has no effect. Batch API provides $context as the last parameter of the op functions, you can take it by ref and add messages and results.
- Using $context['sandbox'] is only relevant for multipass operations (one single operation that gets called repeatedly until it declares itself as 'finished'. Not your case, so you can drop those lines.
Comments
Comment #1
gddI had been meaning to look into that, thanks for the tips. Fix committed.