Closed (fixed)
Project:
Taxonomy Delegate
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2009 at 13:53 UTC
Updated:
28 Jan 2011 at 20:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
Leeteq commentedNot sure if this should be regarded as a bug. I think it is generally preferable if modules require role access even for uid1, when such a feature is in place.
Personally, I never use admin1 for other than system update(.php) tasks, in particular to be sure at all times that I quickly spot whenever the role-based security settings does not work well.
If working with uid1, you may be fooled to believe that all is well, and potentially waste time if finding out "too late" that something is wrong with the security.
Comment #2
cyberwolf commentedIMHO it would be good to allow users with the permission "administer taxonomy", including admin users, to be able to see the menu item.
Quick fix in _taxonomy_delegate_access():
/**
* Menu access checking function.
*/
function _taxonomy_delegate_access() {
global $user;
return count(_taxonomy_delegate_my_vocabularies()) > 0 || user_access('administer taxonomy');
}
This also allows admin to add new menu items pointing to category_admin. Otherwise, he gets the message: "The path 'category_admin' is either invalid or you do not have access to it.".
Comment #3
mrfelton commentedI agree. Admin should be able to access the page. Patch attached.
Comment #4
dkingofpa commentedPatch for currently released version (1.3). I can't use a moving target like dev in my environment. Moved the user_access('administer taxonomy') call to _taxonomy_delegate_my_vocabularies() so admin can see all delegated vocabularies as well as the menu link.
Comment #5
pearcec commentedRerolled this from a CVS tagged checkout of Drupal 6.x-1.3 so it works from a drush make.
Comment #6
nancydruSimilar idea, different code. There is now a setting to show the menu to admins.
Committed to 6.x-1.x-dev.