TCPDF problem with Image containing single quote

My impression is that the problems with images (and I have them as well) is somehow wrapped up in the 3rd party PDF utilities, thus there is little chance of problem resolution through this channel.

I have tried both dom and TCPDF and get different (but fatal) errors with each. It doesn't look like there's an easy solution through either utility.

Here's a sample error from my site:
TCPDF ERROR: [Image] No such file or directory in /home/boab-info/htdocs/drupal/sites/ruralpracticechange.boab.info/files/00-intro-title-campbell-sm.jpg?1229090688

Note: there is an image called "00-intro-title-campbell-sm.jpg" in the path specified, but what the "?1229090688" means or where it comes from is totally opaque to me.

THEREFORE: my question (without breaking the intent of the current thread) is to ask...is there a way to selectively include/hide the Print PDF option on selected content types?

This will allow me to provide PDF options on types where it currently works (eg, simple css, low image load) and avoid it on content types where I have known problems.

Thanks,

JB

@skyredwang: TCPDF doesn't have problems with your "image filenames with spaces" as dompdf did, but I do think it has a problem with single quotes.. I will try to commit something soon that will fix that. I'll notify you here when I do.

@boabjohn: your problem is the same as reported in #420460: problem with images with a numerical query. I really do need to know from where that numerical query is coming from.. Can you please provide any answers to that in the proper issue?

João

Actually, after developing the fix, I decided that I really shouldn't be trying to fix problems with TCPDF inside the module (Pandora's box and all...)..

Please create an issue for the problem of single quotes in image filenames in TCPDF's issue queue. TCPDF's maintainer is usually fast in fixing things on his side.

João

That's what the fix I did was doing.. It worked, but the problem is that if I start fixing everything that TCPDF can't handle I will end up with a lot of code in the module side which will eventually be obsoleted once TCPDF starts to handle it. This is a bug with TCPDF and has to be fixed by TCPDF.

I will try to come up with an example which doesn't involve Drupal so that Nicola can see that the problem is his code and not the 'TCPDF implementation'. Until then, sorry but you're between a rock and a hard place.. The easiest solution for you is to stop using single quotes in your filenames.

Anyway, this will all become moot once I test and merge #419296: Use wkhtmltopdf for PDF generation. I am pretty sure that everyone will kiss TCPDF and dompdf goodbye at that point.

João

I have upgraded to TCPDF 4.5.0043 yesterday and the problem of the single quotes is fixed in that version. Something that Nicola did between 4.5.0032 and 4.5.0043 solved it (possibly this fix on 0036: All tag attributes, such as p align="center" must be enclosed within double quotes.).

So, Nicola was right on that bug report in Sourceforge, there's nothing to be done on his side.

Have you tried with TCPDF 4.5.0043 or later? Is it still giving you problems?

João

Indeed, you're right.. When I tried to reproduce the problem, what happened to me was the reported missing filename was truncated at the single quote. In your case that's clearly not the problem.

The bad part is that I don't know where to look for in trying to reproduce it.. Have you tried removing the quote in the filename? It would be nice to know if the problem is still related to the quote or if it has nothing to do with it.

João

At least something is the problem... I don't have time now to search our history of issues... Can you tell me if you're using the public or the private filesystem method?

I did test both types in my earlier testing, but it would speed up the problem somewhat if I could limit myself to a single one.

João

There is indeed one thing you could do... I think I need to try a PDF of your page, and not my (simpler) pages to try to find out what the problem is.. Can you please enable the printer-friendly version for anonymous users so that I can access it? I will try to access http://greatbrewers.com/list/47413.

If you need to, please delete/comment out the build_mode = NODE_BUILD_PRINT line.

João

Thanks for the URL. I tracked the problem down to something in Drupal replacing the ' in the filenames with &# 039;. I have added some code to decode that into normal characters so that TCPDF understands it.

João