"Force Private" setting on attachments module breaks in the acidfree module
dmuth - January 3, 2006 - 05:43
| Project: | Acidfree Albums |
| Version: | 4.6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
In the process of writing a patch for the attachment module to understand private files, I discovered that the files could not be downloaded. The cause of this is that acidfree's acidfree_filemanager_download() function does not find an acidfree node for the file, and assumes that permission should be denied in that case.
The patch I've attached modifies the function so that the absense of a node is treated as "this file is not handled by acidfree, so return true and let another module take care of it".
-- Doug
| Attachment | Size |
|---|---|
| acidfree.diff.txt | 796 bytes |
#1
this seems like an acidfree specific issue.
#2
I don't think returning true is what you want. Returning true would allow for the file to be downloaded. If it is not ours, we should return something that is not true and not false and not an array. So here is a patch that does returns null...
Let me know if this fixes your problem.
#3
Well, I committed the patch. So I hope it works. It is in CVS awaiting repackaging in a few hours.
#4