In the process of writing a patch for the attachment module to understand private files, I discovered that the files could not be downloaded. The cause of this is that acidfree's acidfree_filemanager_download() function does not find an acidfree node for the file, and assumes that permission should be denied in that case.
The patch I've attached modifies the function so that the absense of a node is treated as "this file is not handled by acidfree, so return true and let another module take care of it".
-- Doug
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | filemanager-download.patch | 884 bytes | vhmauery |
| acidfree.diff.txt | 796 bytes | dmuth |
Comments
Comment #1
drewish commentedthis seems like an acidfree specific issue.
Comment #2
vhmauery commentedI don't think returning true is what you want. Returning true would allow for the file to be downloaded. If it is not ours, we should return something that is not true and not false and not an array. So here is a patch that does returns null...
Let me know if this fixes your problem.
Comment #3
vhmauery commentedWell, I committed the patch. So I hope it works. It is in CVS awaiting repackaging in a few hours.
Comment #4
vhmauery commented