yched noted back in #323112: Vertical Tabs that Anonymous is not properly getting replaced:

Lack of validation

Might also be worth putting some validation for the date? Currently I can type in:

Lack of validation

I imagine I can do similar things elsewhere, too.

Comments

kkaefer’s picture

*subscribe*

kkaefer’s picture

Status: Active » Needs review
StatusFileSize
new641 bytes

This patch validates the date and uses 'Anonymous' if the user textfield is empty.

kkaefer’s picture

The 'validation' function also allows dates past the 31st of a month, but since we're not doing hard validation I don't think this is a concern.

dmitrig01’s picture

Title: Authoring information vertical tab is a bit funky » Authoring information sucks

Let's fix this for real - let the user enter a human-readable date and find some way to let the user select either Anonymous or an auth'd user. Additionally, for this patch, Anonymous username is a variable (I forget what)

moshe weitzman’s picture

Title: Authoring information sucks » Authoring information vertical tab mishandles Anonymous.

Javascript validation is a bigger issue than this issue, IMO. Also, lets use descriptive titles. Lets just fix the bug.

Bevan’s picture

Issue tags: +vertical tabs

tagging

Status: Needs review » Needs work

The last submitted patch failed testing.

mgifford’s picture

Status: Needs work » Needs review
StatusFileSize
new833 bytes

I haven't fixed the bug, but the patch needed to be updated.

dave reid’s picture

StatusFileSize
new771 bytes

Previous patch had some of the validation code left in. Revised patch that just fixes the bug. This is also the same code we're now using with the D6 backport of Vertical Tabs.

dave reid’s picture

Assigned: Unassigned » dave reid
dave reid’s picture

FYI committed this to the backport contrib module.

MichaelCole’s picture

#9: 431300-nodejs-authoredby-D7.patch queued for re-testing.

dmitrig01’s picture

StatusFileSize
new769 bytes

I know that now it's getting really nit-picky but let's optimize and use one var statement instead of two.

joachim’s picture

Status: Needs review » Needs work

Looks good.

But this should be using the setting for Anonymous user name at admin/config/people/accounts.

dmitrig01’s picture

Status: Needs work » Needs review
StatusFileSize
new1.66 KB

Good point.

jzacsh’s picture

Status: Needs review » Reviewed & tested by the community

Patch works, name changes appropriately now.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Looks good. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -vertical tabs

Automatically closed -- issue fixed for 2 weeks with no activity.