How would I find out if my theme (Artist C01) is over riding this module? Anything I add in the Appearance entry is not changing the submitted by line.

Comments

nancydru’s picture

Status: Active » Postponed (maintainer needs more info)

The simplest thing would be to switch to a core theme. But I'm guessing that you already have the answer. I have tried a half dozen themes at least and they all work.

nancydru’s picture

Well, I just encountered two more themes that are not honoring theme('node_submitted'). You'll need to submit an issue against that theme. I opened an issue on Pixture_Reloaded (#453312: Submitted by not honoring theme overrides). If you do, please post a link to the issue back here.

Apollo610’s picture

Status: Postponed (maintainer needs more info) » Postponed

Hi guys - has anyone successfully gotten this contrib to work with Acquia Marina?

I've been toying with it for the past 30 minutes or so (AM has a handful of customization options), to no avail. I have a feeling this may be one other theme that's not compatible (I've tried both the recommended and dev versions of this contrib).

Thanks!

nancydru’s picture

I suggest that you open an issue on that theme to print $submitted;

Apollo610’s picture

Done, filed an issue request with the Acquia Marina folks. Thanks!

stephthegeek’s picture

Ah interesting! We have content type-specific settings for the byline via Acquia Marina's theme settings, so of course that's overwriting the module's modifications. The theme does print $submitted; but we'll need to put in a check for the submitted_by module.

nancydru’s picture

Works for me.

Apollo610’s picture

FYI - Acquia Marina's been patched and Submitted By now works.

nancydru’s picture

Great, thanks.

nancydru’s picture

Status: Postponed » Closed (fixed)
brisath’s picture

Status: Closed (fixed) » Active

I've submitted the issue to the theme I am using http://drupal.org/node/493850 However, I haven't gotten any response to this yet. Since this is a issue with some other themes too, I'm wondering if there is a solution that can come from this module. Or, are we at the mercy of the individual theme developers? Is there some kind of workaround that can be done within the code of the "Submitted By" module?

nancydru’s picture

Status: Active » Closed (fixed)

Unfortunately I don't see any way this module can fix the theme if it is not doing the $submitted correctly. You, however, are fee to update the theme on your site until such time as the theme maintainer gets around to it (if they ever do - too many themes are "abandonware").

brisath’s picture

Status: Closed (fixed) » Active

Thanks. I've made a lot of changes to the theme anyway, so I would like to change it myself but my knowledge of the code is very limited right now. Can you provide steps for the changes to $submitted that I should make?

nancydru’s picture

For ArtistsC01, go to node.tpl.php and change

    <?php if ($submitted): ?>
      <span class="submitted"><?php print t('Submitted by !username on !date', array('!username' => theme('username', $node), '!date' => format_date($node->created))); ?></span>
    <?php endif; ?>

to

    <?php if ($submitted): ?>
      <span class="submitted"><?php print $submitted; ?></span>
    <?php endif; ?>

See how simple doing it right can get.

brisath’s picture

Status: Active » Fixed

It worked! That was an easy fix. Thanks for providing the instructions.

nancydru’s picture

I also posted the solution in the theme's issue queue, but they haven't done anything in a year.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Shai’s picture

FYI, same problem for Zen 6.x-2.0.

Solution in #14 worked great.

Do note though that in Zen there is a flag variable used for determining whether the submitted stuff should be printed at all. It's called $display_submitted. I'm not sure why testing for that is any better than just plain old, if ($submitted):.

nancydru’s picture

It's a theme setting to globally remove that line. IMHO, this module is gererally a better solution.

Shai’s picture

@NancyDru,

I'm using Zen 2.0 and I just don't see the theme-setting you are talking about. I checked at admin/build/themes/settings/mysubtheme and at admin/build/themes/settings/zen and it's not there.

I'm having no trouble with the module when getting rid of the hard coding and adding <?php print $submitted; ?> to node.tpl.php, as you demonstrated in this thread. But it would be important to add Zen on the project page to the list of themes that require editing of node.tpl.php in order for this to work. Maybe it was Zen 1.x that had the theme setting???

Shai

aquamars’s picture

not working with Orange theme

nancydru’s picture

1) Make sure you've enabled it on the theme configuration page.
2) Check that your theme's node.tpl.php actually displays $submitted rather than some other technique. If it does not, report it to your theme's issue queue, because it is a theme error.

mattwmc’s picture

Thanks #14.

Same issue with Celju theme.

It has this:

 <?php if ($submitted) : ?>
      <div class="submitted">
        <?php print t('By ') . theme('username', $node) . "  - " . format_date($node->created, 'custom', "F jS, Y"); ?>
      </div>
    <?php endif; ?>

nancydru’s picture

Once again, if you don't see print $submitted, you need to encourage your theme's developer to get on board with the Drupal way.

mattwmc’s picture

Yep, I made them aware. :)

luco’s picture

@NancyDru hey, thanks for the solution on #14. I run Zen accross all my sites and it worked like a charm on the one I need to run Submitted By.

maybe it could be included in the documentation ;)