Added views support and a new widget style (patch attached)
scottmartinnet - April 13, 2009 - 18:37
| Project: | Vote Up/Down |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | ingo86 |
| Status: | closed |
Description
I've done some development on this module to allow it to interface with the views system so that you can display a widget in views and to create a new widget style ("combined") which combines the up/down widget and the points display into a single widget.
I'm new to the patch process, so let me know if I've done something wrong. I've attached a .tar.gz file which contains a patch and three new theme files.
#1
#2
You included the file as a .diff file, I think it might need to be a .patch file
#3
This is exactly what I´m missing. Should I learn how to patch or will this be added to an update soon?
#4
I might, or I do? I followed the instructions here, which are about using the cvs diff command: http://drupal.org/patch/create
#5
After a bit of a headache, I now have this patch working. It does not need to be a .patch file to use with Eclipse, but I am not sure about other IDEs or what the Drupal etiquette is here for which file type to use. For those - like me up until a few minutes ago - who don't know how to apply this patch in Eclipse, just create a project that includes the module, right click and on that menu go to Team>Apply Patch..., choose the .diff file and click next, choose the correct folder and hit finish.
Note that you will have to manually create vote_up_down_widget_combined.tpl.php and vote_up_down_points_combined.tpl.php files, but the correct code is near the end of the .diff file.
Overall, great patch once you jump through the hoops needed to get it working. Thank you, scottmartinnet; you just saved my day. :)
#6
Oh yay, just what I was looking for! :D I'm looking forward to testing this.
#7
could someone provide this as a .patch, so that also users
with no programming skills can give it a try? Thank you
#8
Is there a screenshot of what the widget looks like?
#9
Can someone please supply the patch for this? It would be really appreciated.
#10
a patch file.
I created this from diff in my local directory. To apply:
1. download it to your vote_up_down module directory
2. patch -p1 -i vote_up_down.patch
3. Download the original .zip file and copy files in themes to your module's theme directory.
#11
is there a picture of what the new widget looks like? Does it look like Drupalit widget?
#12
I have a problem with patch in # 10, thank you nevertheless
patching file vote_up_down.css
patching file vote_up_down.module
Hunk #4 FAILED at 219.
Hunk #6 succeeded at 308 with fuzz 2 (offset 1 line).
Hunk #7 succeeded at 577 (offset 1 line).
Hunk #8 succeeded at 657 (offset 1 line).
Hunk #9 succeeded at 805 (offset 1 line).
Hunk #10 succeeded at 823 (offset 1 line).
1 out of 10 hunks FAILED -- saving rejects to file vote_up_down.module.rej
patching file vote_up_down_views.inc
#13
This is an interesting idea. I second putting this feature into the actual module.
#14
After committing other patches the old patch is broken. I will work on it to make it working again on 1.x-dev.
#15
Views and vote up down are already compatible together using:
Row style: NodeThis is a bit limitative, I will work to provide an integration with fields too.
#16
Views support now added to vote up down 6.x-1.0-beta6.
#17
Automatically closed -- issue fixed for 2 weeks with no activity.