Issue related with #358082: jQuery 1.3 in Drupal 6.x

To help ThickBox work with jQuery 1.3.2 in jQuery Update can we please remove the @ in the selectors. It was depreciated as of 1.2 and removed in 1.3. Change highlighted below.

jQuery 1.2.x:
$("a[@href*='admin/build/testing']").doSomething();

jQuery 1.2.6 and 1.3.x:
$("a[href*='admin/build/testing']").doSomething();

More detail at http://docs.jquery.com/Selectors/attributeHas#attribute

CommentFileSizeAuthor
#1 thickbox_js.patch1.19 KBjcmarco
#1 thickbox_login_js.patch1003 bytesjcmarco
thickbox_js.patch1.19 KBjcmarco

Comments

jcmarco’s picture

jcmarco commented
StatusFileSize
new thickbox_login_js.patch1003 bytes
new thickbox_js.patch1.19 KB

Updated patch to last dev version
Also added a patch for thickbox login

jcmarco’s picture

jcmarco commented
Status: Active » Needs review
frjo’s picture

frjo commented
Assigned: Unassigned » frjo
Status: Needs review » Fixed

Thanks for the heads up on this issue and the patch. Committed to 6-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.