I would like to see the functionality of this module in Drupal 7 core. As a first start I tried to port the HEAD version to Drupal 7.
What I did was change the .info file to include the files and convert the DB queries in the .module file to DBTNG according to the docs.
What did not work, was disabling the module.
Maybe if someone would help, a 7.x-1.x-dev release could be created.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | block_class-DRUPAL-6--1_d7port.patch | 8.85 KB | dboulet |
| #5 | block_class_d7.patch | 5.17 KB | berenddeboer |
| #1 | block_class_d7.patch | 3.11 KB | tstoeckler |
Comments
Comment #1
tstoecklerOh, and here's the patch...
Comment #2
johnpitcairn commentedWatching...
Comment #3
chichiMi5 commentedsub
Comment #4
dboulet commentedFollowing... will test patch when time permits.
Comment #5
berenddeboer commentedI've attached a new port based on the 1.3 version. The head and dev versions of this module are garbage.
This port has the advantage that NO change to the theme's block.tpl.php template is needed. Install this module, and it works. Makes this much more user-friendly for developers.
Comment #6
dboulet commentedAwesome, thanks for the patch berenddeboer! Here's a new patch, based on 1.x-dev. Sure, the HEAD and 2.x-dev releases are no good, but the 1.x-dev version is perfectly usable.
A few changes I made:
-Minor white space tweaks
-Modified description on block form
-Modified README.txt
Comment #7
will_in_wi commentedSubscribe
Comment #8
dboulet commentedAny chance of getting a 7.x-dev branch started, based on #6?
Comment #9
todd nienkerk commentedI'll take a look at this in the next couple of days.
berenddeboer: What about the 6.x-1.x-dev branch makes it garbage?
dboulet: The 6.x-2.x-dev branch includes significant new functionality that was, unfortunately, abandoned due to time constraints. It does (or is supposed to) some really cool stuff with pre-defining available block classes in a theme's .info file to allow the site admin to choose classes or styling attributes using checkboxes or a drop-down list instead of a text field to add class names. This functionality was intended to make the module extremely easy to use for admins and theme developers to customize blocks. It would be great to add this functionality to a 7.x-2.x-dev branch, but I don't know who is available to pick this up.
Comment #10
dboulet commentedThat sounds like a nice idea, but I'm wondering how far we should take it. I would be scared that after a while, we would just be replicating Skinr.
Comment #11
todd nienkerk commenteddboulet: The introduction of Skinr was the primary reason for abandoning work on the advanced functionality of Block Class 2.x. IIRC, the technique Block Class 2.x was implementing was a bit more efficient, but it lacked the flexibility and scope of Skinr.
Comment #12
berenddeboer commentedTodd, the 6.x-1.x-dev branch doesn't have any code that does anything as far as I remember. It simply didn't do anything. There might be bright ideas waiting to come to fruition, but as best as I remember when I tried to use it, it had no code that did anything.
Comment #13
todd nienkerk commentedI have created a 7.x-1.x-dev branch and applied the patch in #6. Additionally, HEAD is now in sync with 7.x-1.x-dev.
Here are instructions on how to check out the 7.x-1.x-dev branch.
Comment #14
todd nienkerk commentedberenddeboer (regarding #12): The 6.x-1.x-dev branch is the latest build of 6.x-1.x. I'm not sure what you mean by "it [has] no code that [does] anything," as it's essentially the same as the 6.x-1.3 release.
Comment #15
dboulet commentedGreat, thanks Todd! I'm going to go ahead and mark this issue as fixed then. Any new features or bugs for this branch can be reported in new issues.